Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source_hscroll: Set max_width to sview->cur->file_buf.max_width #147

Closed
wants to merge 1 commit into from

Conversation

MaskRay
Copy link

@MaskRay MaskRay commented Oct 26, 2017

The old max_width disallows horizontal scrolling when the longest line
can be displayed in one screen. Remove this restriction.

Signed-off-by: Fangrui Song i@maskray.me

@iandinwoodie
Copy link
Member

@MaskRay you will need to sign-off your commit for the patch to be considered.

@MaskRay
Copy link
Author

MaskRay commented Apr 26, 2018

@idinwoodie Thanks. Done

@brasko
Copy link
Contributor

brasko commented May 10, 2024

hi @MaskRay . I know it's been ages, however, do you still have an interest in pushing this forward?

@MaskRay
Copy link
Author

MaskRay commented May 10, 2024

hi @MaskRay . I know it's been ages, however, do you still have an interest in pushing this forward?

Rebased!

(I am using cgdb+rr)

The old max_width disallows horizontal scrolling when the longest line
can be displayed in one screen. Remove this restriction.

Signed-off-by: Fangrui Song <i@maskray.me>
@brasko
Copy link
Contributor

brasko commented May 11, 2024

Oh, I see what you want to do here, you want to be able to print the variable under the cursor? (if the cursor could freely move in the source window)

@MaskRay
Copy link
Author

MaskRay commented May 11, 2024

Oh, I see what you want to do here, you want to be able to print the variable under the cursor? (if the cursor could freely move in the source window)

I don't remember the connection between this PR and #141.

But I just checked: currently the key l arbitrary stops scrolling at some column while this PR removes this restriction.

@brasko
Copy link
Contributor

brasko commented May 16, 2024

OK. We aren't going to add this behavior into cgdb as is.

Instead, we would attempt to make the source window cursor movable. I'll consider doing this at some point. I'm closing this for now then.

@brasko brasko closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants