Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ncursesw should link with tinfow. #220

Merged
merged 1 commit into from Feb 6, 2020

Conversation

iandinwoodie
Copy link
Member

This patch is a response to issue #219. Ncursesw was linking with tinfo when it should have been linking with tinfow.

This issue is not unique to cgdb. I've included a brief list of reference issues and patches below:

[02/03/2017] - A similar problem occurred in the tig repository (issue 568).
[04/11/2017] - The issue was in tig by using tinfow with ncursesw (pull request 685).
[03/26/2018] - The seeming exact problem we are seeing surfaced as a Gentoo bug (bug 651552).
[03/31/2018] - The Gentoo solution for mutt matched the change set for tig (attachment 526196).
[10/21/2018] - We see a similar patch for gdb on Gentoo. (commit 63d9497).

Symptoms and solution are pretty straight forward. @jgehrig sorry for the delay. Can you please test this on your Gentoo machine and report back. Additionally, if it is successful, can you include the updated ldd output in a comment on this PR.

This patch is a response to issue cgdb#219.

Signed-off-by: Ian Dinwoodie <dinwoodieian@gmail.com>
@jgehrig
Copy link

jgehrig commented Jan 31, 2020

Thanks @iandinwoodie!

Sure, I can test and provide ldd output.

I don't have access to that machine right now... I will take a look at this Monday.

@brasko
Copy link
Contributor

brasko commented Feb 1, 2020 via email

@jgehrig
Copy link

jgehrig commented Feb 4, 2020

Once I apply the patch to my system, cgdb works fine. Thanks!

Here is the ldd output:

$ ldd /usr/bin/cgdb
        linux-vdso.so.1 (0x00007ffc42fea000)
        libncursesw.so.6 => /lib64/libncursesw.so.6 (0x00007f73b04e7000)
        libreadline.so.7 => /lib64/libreadline.so.7 (0x00007f73b0496000)
        libtinfow.so.6 => /lib64/libtinfow.so.6 (0x00007f73b0458000)
        libutil.so.1 => /lib64/libutil.so.1 (0x00007f73b0453000)
        libstdc++.so.6 => /usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/libstdc++.so.6 (0x00007f73b01d6000)
        libgcc_s.so.1 => /usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/libgcc_s.so.1 (0x00007f73b01bc000)
        libc.so.6 => /lib64/libc.so.6 (0x00007f73affe7000)
        libm.so.6 => /lib64/libm.so.6 (0x00007f73afea6000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f73b05bf000)

@iandinwoodie iandinwoodie merged commit a8a567f into cgdb:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants