Issue #13 allow short algebraic notation moves. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a San class to parse and store the internals of a short algebraic move. Add san_to_long method to Game to convert the san move to the long version. Add apply_san_move method to Game to apply the move Replace xrange with range so that tests run in python3 Add find_all_pieces method to Board similar to find_piece, but returns a list of all indexes instead of just the first one. Add tests to cover all the new code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a San class to parse and store the internals of a short algebraic move.
Add san_to_long method to Game to convert the san move to the long version.
Add apply_san_move method to Game to apply the move
Replace xrange with range so that tests run in python3
Add find_all_pieces method to Board similar to find_piece, but returns a list of all indexes instead of just the first one.
Add tests to cover all the new code.