Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new legacy version for API 16-20 users #333

Closed
3 tasks done
Lineflyer opened this issue Jan 2, 2022 · 7 comments · Fixed by #343
Closed
3 tasks done

Create new legacy version for API 16-20 users #333

Lineflyer opened this issue Jan 2, 2022 · 7 comments · Fixed by #343
Assignees
Labels
Feature Request New feature or request

Comments

@Lineflyer
Copy link
Member

Lineflyer commented Jan 2, 2022

Current release is only working for API>=21 according to smoke tests.
Therefore the minSDK has been raised to 21.

If we want to publish a version for API 16-20 users we need to update the legacy branch accordingly.
I am setting the foundation for this next days by:

  • Conservering current legacy state into legacy_API15
  • Updating legacy to the most current working state (seemingly before new settings have been introcuded)
  • Cherry-Picking some later changes onto legacy (i.e. New icon, User Agent fix, Hint for text input)

When this is done we can try to work on a legacy release as described in #266 (comment)

@Lineflyer Lineflyer self-assigned this Jan 2, 2022
@Lineflyer Lineflyer added the Feature Request New feature or request label Jan 2, 2022
@bekuno
Copy link
Member

bekuno commented Jan 2, 2022

I propose to use the release state 2020.08.21 as legacy base.
The new release will only delivered to devices with API21 onwards. Older devices will therefore further run with the old release.

@Lineflyer
Copy link
Member Author

@bekuno
I meanwhile updated legacy basically to 2020.08.21 with some on-top cherry-picked fixes for:

  • New icon
  • User agent to enable online maps
  • Hint for the text input field in cartridges

It compiles and runs for me in emulator API 16.
@bekuno Could you doublecheck the modified build.gradle on legacy? I removed the versioning logic but kept other recent changes (e.g. dependencies, NDK version, etc.) Hope this is OK.

@bekuno
Copy link
Member

bekuno commented Jan 3, 2022

I created PR #343 with two change suggestions.
The other changes are fine, imho.

@bekuno bekuno linked a pull request Jan 3, 2022 that will close this issue
@bekuno bekuno closed this as completed Jan 3, 2022
@Lineflyer
Copy link
Member Author

Let me reopen this to track until release of a legacy version.

@Lineflyer Lineflyer reopened this Jan 3, 2022
@Lineflyer Lineflyer pinned this issue Jan 4, 2022
@Lineflyer
Copy link
Member Author

AFAIR from c:geo the sequence for publishing a legacy (see also: cgeo/cgeo#8602 (comment)) would then be:

  • Create a release from legacy with a version number < version number from release
  • Publish both versions in parallel (or start with legacy and then release

Logic should be: versionCode_oldrelease < versionCode_newlegacy < versionCode_normalrelease

@Lineflyer
Copy link
Member Author

On the weekend my plan would be to do the following:

  • Build the legacy version from legacy with a versionCode in between 20220102 (the problematic beta) and 20220110 (the to be pubslihed beta), e.g. 20220105
  • Publish it
  • Publish the current beta 20220110 as production release

This should make the legacy version available to API 16-20 and the current beta available to API21+

@Lineflyer
Copy link
Member Author

Legacy version 2022.01.14-legacy (Code: 20220105) is part of the ongoing release. See #251

@Lineflyer Lineflyer unpinned this issue Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants