Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opening cartridges from system file browser / apps like WhatsApp #39

Open
jakedot opened this issue Feb 19, 2020 · 7 comments
Open
Labels
Feature Request New feature or request

Comments

@jakedot
Copy link
Contributor

jakedot commented Feb 19, 2020

Is your feature request related to a problem?
When I want to play a new cartridge, I have to download it (possible by e.g. opening the wherigo.com link with WhereYouGo), but a downloaded cartridge can not be opened directly from the android file browser with WhereYouGo.

Describe the solution you'd like
Allow opening a cartridge from the system storage, either from anywhere by opening it (declaring in AndroidManifest.xml an intent filter for .gwc and .gwz) This would by the way also provide a workaround for the problem that c:geo attempts to open cartridges, even if not solving that it pretends to be able to open any file with the line <data android:mimeType="application/octet-stream" />.

Additional context
See cgeo/7663

@jakedot jakedot added Feature Request New feature or request Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility labels Feb 19, 2020
@Lineflyer Lineflyer removed the Unverified Issue not yet confirmed/reproduced or feature requests not yet checked for plausibility label Feb 22, 2020
@jakedot
Copy link
Contributor Author

jakedot commented Feb 26, 2020

If someone else wants to have a look at this feel free to reopen PR #40 and push changes there (if that's possible? IDK)

@hakuchi
Copy link
Contributor

hakuchi commented Feb 27, 2020

WhereYouGo is not able to import a cartridge using a browser, explorer or other app(tested by modifying a little bit the code from your PR).
WhereYouGo can open the cartridge only if you put them into the correct folder and open it in the app by clicking on "Play".

I think WhereYouGo need in app a import function and after that, opening a gwc from a file explorer will work. c:geo or navigation apps can import gpx(or other formats) and so the opening in a file explorer works.

But who need this function? If you manage many cartridges over email or WhatsApp you should be able to putt it after receiving into the correct folder.

@SchoolGuy
Copy link
Contributor

Also what needs to be taken care of in such a situation is that you may not be able (or don't want) to write the log files back into the folder where you opened the cartridge from. If WhereYouGo would move the cartridge automatically to its selected storage through "opening" that would indeed be am improvement in my eyes.

@jakedot
Copy link
Contributor Author

jakedot commented Feb 27, 2020 via email

@jakedot
Copy link
Contributor Author

jakedot commented Mar 13, 2020

Anyone interested can test my implementation in PR #40 - I think it could still be polished a bit but works for now.

@hakuchi
Copy link
Contributor

hakuchi commented Mar 14, 2020

tested with file explorer and works only if the file is in the folder I set in the settings.
If I move the cartridge to a other folder it is impossible to play

@jakedot
Copy link
Contributor Author

jakedot commented Mar 14, 2020

Yes, this is intentional. But the cartridge is correctly saved to the folder in the first place?

I will probably add some messages in the import screen if there is a cartridge with the same filename already, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants