Have a link to "related webpage" in cache details

[Lineflyer]

From support mail:

GC.com allows naming a related webpage.
Sometimes this is used to refer to important cache information or even necessary for solving a mystery.
Example: GC3BCT0

Unfortunately the link to the related webpage is not visible in c:geo.
It could be added in the hint section like the spoiler-image link.

[burdavac]

Hi,
I'm student of Faculty of Electrical Engineering on CTU. The goal of my semestral work in the subject Open source programming is to join some existing project and do some useful tasks to improve or extend that project.

Because I am also user of c:geo, I selected this issue on this project and would like try to do something which could be usefull.

[Bananeweizen]

@hanxovic That sounds great. But please be prepared that this might take several hours (over the course of several days), if you have never contributed to such a project before. This is because you need to get the development environment running, get to understand the existing code, the existing developers may complain about some things not matching the remaining code structure and so on. If you feel comfortable with those circumstances (which BTW. are part of most larger open source projects), then we will happily lead you along that path.

While all direct development related information is managed via this issue tracker, a lot of discussion also happens in chats. So you might find much more help and tips there, if you join the channel #cgeo on the freenode network using an IRC client.

[burdavac]

Thank you for your answer. I know it's a long time before I understand the application code. This is precisely the aim of our course - to understand how community around open-source project works and to understand code of other coders. I hope I can do it and I can help :-)

[Bananeweizen]

(set myself as "stand-in" assignee, as it is not possible to assign issues to arbitrary people)

[burdavac]

Hello,
I went through the code and perhaps I understood everything I need.
I worked on adding link to related webpage and I hope it would be done.

Here is link to patch file: https://dl.dropbox.com/u/25926349/0001-Adding-feature-request-2321.patch

I'll be glad for any comments, thank you.

EDIT: here are some GC codes with "related webpage": GC2JKPW GC39521 GC3BCT0

[SammysHP]

Please send us a Pull Request with your commit.

edit: Added some comments in your commit.

[Eldenroot]

cgeo team needs more like you hanxovic ;) keep good work

[Lineflyer]

mmh.. have these commits been merged? Does not look like that.
@hanxovic Do you still have the code for that prepared?

[rsudev]

He never sent a PR for this, AFAICS. It would need some adjustments to still fit into the current codebase, but that should not be too much work. Should I give it a try?

[Lineflyer]

@rsudev I do not see any urgent need for this (I just noticed today that a cache had a related website and we do not show that...but this is rarely useful).
I personally would much more appreciate an implementation of #1793 if you think you have some spare time ;))

Maybe @hanxovic comes back to this next days anyway.

[Eldenroot]

any news?

[Olestas]

Hello, guys? Why this is not implemented? It is needed very often. I dont want to open browser on each cache, to see, if it has related webpage inside at all.. Please just add this, it is just a link. Could not be so hard to add. Already missed some checkers and other info, because it was integrated into Related web pages...

[mucek4]

Cause we never got PR from @hanxovic and nobody had time to do it. @Olestas if you feel you can "just add this" feel free.

[Olestas]

No, I am usual user, not a coder, but I don't believe adding display of usual http link can be so hard. And I don't know, what a PR is.

[mucek4]

Pull request

[Lineflyer]

We should ask @hanxovic again if he is still willing to provide a PR.
He coded a solution in his fork at least.

If not, we should remove the assignment.

[burdavac]

Hello, here was pull request: #2577.
Sorry, but now I don't have any spare time to check differencies and finish this feature. Anyone can take my code and continue with implementation.

[samueltardieu]

I did a very simple implementation which adds a bold link at the top of the long description. This is better than nothing, and adding a field in our database is not a good idea, as this related web page is not even present in the GPX from geocaching.com.