Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect error message structure #2413

Closed
samueltardieu opened this issue Jan 19, 2013 · 2 comments
Closed

Incorrect error message structure #2413

samueltardieu opened this issue Jan 19, 2013 · 2 comments
Labels
Bug Issues classified as a bug Prio - Low A minor issue not having significant influence to a feature/function.

Comments

@samueltardieu
Copy link
Member

The message displayed from Settings when the user cannot log in is badly structured. It gives something like:

Login failed because of You have not agreed to Geocaching.com license agreement..

Wrong sentence composition + double dots at the end.
@marstaj
Copy link

marstaj commented Mar 13, 2013

It seems that the first part of the sentence is fixed, and the second one is from the server and if you put it together, it makes wrongly structured sentence. I duplicated the problem and I`ll try to fix it.

marstaj pushed a commit to marstaj/c-geo-opensource that referenced this issue Mar 13, 2013
Fixes cgeo#2413 - In English it is better to use "Login failed: Messa…
6210c6b 
…ge from

server" since the message from server can be a whole new sentence.
@marstaj
Copy link

marstaj commented Mar 13, 2013

In English it is better to use "Login failed: Message from server" since the message from server can be a whole new sentence.

This (in my opinion) looks better.

Screenshot_2013-03-13-16-14-24

@marstaj marstaj mentioned this issue Mar 13, 2013
Closed
@rsudev rsudev closed this as completed in e909ad1 Mar 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues classified as a bug Prio - Low A minor issue not having significant influence to a feature/function.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samueltardieu @rsudev @marstaj