Refresh caches + no internet = normal progress

[SammysHP]

From mail:

1. disable all internet connections
2. open a list, click menu, refresh (or do it with a single cache?)
3. the progress dialog appears, no warning, that there's no internet

[Lineflyer]

Confirmed....
It is just looking like normal (very fast) progress.
It is "progressing" faster than when high speed internet access is availabe.

[samueltardieu]

Yes, this is expected, because the loading fails very fast :)

When should an error be signalled? When the cache description cannot be refreshed? When the logs cannot be refreshed? Either? Both?

[rsudev]

I think the absence of a connection should be detected whenever it happens (can be at any point in time during the refresh) and signaled to the user. The the process should stop.

[samueltardieu]

What I'm saying is that we have at least three possible causes of failure:

• Internet might be down
• geocaching.com might be unreachable or useless (because Internet is down or geocaching.com is down or in maintenance)
• a site hosting an image might be down (because Internet is down or the site is down or in maintenance)

I'd prefer to detect the second event (geocaching.com being unusable) rather than the first one. Internet might be up and the refresh process might fail anyway because of the second one.

[SammysHP]

I think we should display a short report at the end (as a toast) how many caches were refreshed correctly, how many errors and maybe why.

[rsudev]

Being able to distinguish between 'no network' and 'gc.com not responding' could be beneficial anyway, because we can inform the user accordingly. Telling the user 'Connectivity (3G/WLAN) is switched off' or 'No network in reach' or gc.com is not responding, perhaps overload or maintenance' is much more helpful and professional then just 'could not reach gc.com. Check network or try again later' or something.
But this is something that not only relates to cache refreshing but should be baked into c:geo in all areas were an online interaction might happen. And the login state and its cause (no credentials, login failed, token invalid, gc.com behaving badly, ...) are just another facette of the same problem IMHO.

[donEgro]

Hello,

I'm new here, and as a user of c:geo I would participate by solving this problem (I hope it is not-so-hard to solve).

I think there should be a dialog window instead of toast, because no internet connection is an important information and toast can be unnoticed by user.

[marco-dev]

@donEgro
You are welcome. Feel free. You will find all information in cgeo git wiki.

[mucek4]

Joining IRC channel #cgeo on freenode can also help

[SammysHP]

This commit was not enough, there are several other methods that can be called to refresh a cache (e.g. in CacheDetailActivity).

[donEgro]

Ok, I found refresh in:

CacheDetailActivity.RefreshCacheClickListener.onClick()
CachePopup.RefreshCacheClickListener.onClick()

I haven't found any other refresh, do you think it's all?

[donEgro]

I believe this issue can be closed, or if you found some other place, where the caches are refreshed, I'll fix it.

[marco-dev]

Closed. Thank you for your fixes. Anyone feel free to reopen if necessary