Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - #2413 & #2531 #2574

Closed
wants to merge 2 commits into from
Closed

Release - #2413 & #2531 #2574

wants to merge 2 commits into from

Conversation

marstaj
Copy link

@marstaj marstaj commented Mar 13, 2013

I have altered the "Login failed" message for English language so that it has correct structure. You can see this when you try to log in with wrong user name or password.

Secondly I fixed cache log auto-save. List of stored caches now displays that a cas has offline log, which was made by auto-save.

martin.stajner added 2 commits March 13, 2013 17:08
…ge from

server" since the message from server can be a whole new sentence.
Copied saveLog(false) from onStop() also into finish(). List of caches
now gets refreshed, because saveLog() runs while VisitCacheActivity is
still running. saveLog(false) was also left in onStop(), because in
case the activity gets interrupted and finish() is not called, the log
will still be auto-saved.
@buildhive
Copy link

c:geo » c-geo-opensource #1124 SUCCESS
This pull request looks good
(what's this?)

@marstaj
Copy link
Author

marstaj commented Mar 13, 2013

#2413 , #2531

@SammysHP
Copy link
Member

This pull request cannot be merged because it deals with two different issues. Please use separate feature branches instead. Also f80ef7f should go to master because it is no regression fix or important fix. The same for the translation update IMHO.

If there are no objections to any of the commit they can be cherry picked manually.

@marstaj
Copy link
Author

marstaj commented Mar 14, 2013

So is there a way to separate these, or should I fix it in master and commit it again and then make 2 pull requests? Also I cannot find a "delete" button for a pull request, so I guess only you guys can delete this after?

@Lineflyer
Copy link
Member

In my opinion it would be OK to fix both of these issues in master only as they are not critical.

@SammysHP
Copy link
Member

@marstaj
Create two branches from master and cherry pick your commits into them. Then push both to your fork and send a pull request for both.

$ git checkout master
$ git branch feature-2413
$ git branch feature-2531
$ git checkout feature-2413
$ git cherry-pick 6210c6b48bf27addbc0a4aa404e4bd8093439431
$ git checkout feature-2531
$ git cherry-pick f80ef7fd844a6255029f0cb9ae5c4910295c2793
$ git push origin feature-2413
$ git push origin feature-2531

(untested)

@rsudev
Copy link
Contributor

rsudev commented Mar 16, 2013

It looks OK to me and seems to work, so I'll pick locally to master and push

@rsudev
Copy link
Contributor

rsudev commented Mar 16, 2013

merged to master manually and pushed. Thanks for your contribution!

@rsudev rsudev closed this Mar 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants