Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC notification should have target URL to Google Play #8

Closed
Lineflyer opened this issue Aug 5, 2016 · 7 comments
Closed

RC notification should have target URL to Google Play #8

Lineflyer opened this issue Aug 5, 2016 · 7 comments
Assignees

Comments

@Lineflyer
Copy link
Member

Now that we use Google Play beta channel for RC versions it could be better to target the "New RC available" notification to the standard c:geo Google Play URL (like for new release) instead of our own download server.

Advantage:

  • A new RC might be created before it is published to the beta channel
  • Only installations via Google Play will return crash reports and alike
@samueltardieu samueltardieu self-assigned this Aug 5, 2016
@samueltardieu
Copy link
Member

This is not as simple as changing a string, as cgeo-status knows about the release candidate as soon as it has been prepared while it is not yet available on the play store. Are you that only installations through Google Play will return crash reports?

@SammysHP
Copy link
Member

SammysHP commented Aug 6, 2016

Also not everyone uses Google Play.

@Lineflyer
Copy link
Member Author

I suggest to trigger the notification manually (like for release) and target to Google Play.

If we continue using the Google Play beta channel (what would be my goal) we will probably no longer actively promote the direct download.

@SammysHP
Already now non Google Play users will have the problem that the release notification targets to Google Play only. So its not perfect, but nothing new.

@Lineflyer
Copy link
Member Author

We had some questions of users who have installed the beta via Google Play and have clicked on our notification and got alerted by their device about unsafe installation (unknown source) which they considered suspicious.

I think as Beta on Play will be used in future we should change the target and push it manually as suggested before.

Any objections?

@samueltardieu
Copy link
Member

Right now, when we build a release from the CI, it registers a "deployment" status until we make a "release" notification (so that we can follow early deployment stats before notifying people to update and still see people using the previous release).

Similarly, we should change the CI so that it registers a "rc-deployment" status until we make a "rc" notification, right? And as a new release removes the deployment entry, a new RC should remove the rc-deployment entry.

@Lineflyer
Copy link
Member Author

Sounds good

@samueltardieu
Copy link
Member

samueltardieu commented Aug 12, 2016

What has been done:

  • Release candidates builds from the CI now update the rc-deployment status and let the rc status unchanged.
  • Release notification job now includes the ability to select "rc" in addition to "release" or "legacy" to manually notify users of release candidates.
  • A new status "rc-deployment" has been added to cgeo-status and deployed.
  • URL for release candidates has been updated to point to the Play Store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants