Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nightly] Generated waypoints are not shown on map #13683

Open
murggel opened this issue Nov 18, 2022 · 5 comments
Open

[Nightly] Generated waypoints are not shown on map #13683

murggel opened this issue Nov 18, 2022 · 5 comments
Labels
Bug Issues classified as a bug

Comments

@murggel
Copy link
Contributor

murggel commented Nov 18, 2022

Describe your problem!

The "preview" for generating waypoints from variables does not show them on the map.

How to reproduce?

Create waypoint with formula
Enter range for some variables
Open coordinates field of the waypoint
Select "generate waypoints" - dialog opens
Select all waypoints and select "show on map"

Actual result after these steps?

No waypoints are shown

Expected result after these steps?

The selected waypoints should be shown on the map

Reproducible

Yes

c:geo Version

2022.11.16-NB-c66e387

System information

## System information

c:geo version: 2022.11.16-NB-c66e387

Device:
-------
- Device type: SM-G980F (x1sxx, samsung)
- Available processors: 8
- Android version: 11
- Android build: RP1A.200720.012.G980FXXSCDUJ5
- Screen resolution: 1080x2178px (360x726dp)
- Pixel density: 3.3000002
- System font scale: 1.1 / used scale: 1.1
- Sailfish OS detected: false
- Google Play services: enabled - 22.44.17 (150408-488410709)

Sensor and location:
-------
- Low power mode: active
- Compass capabilities: yes
- Rotation vector sensor: present
- Orientation sensor: present
- Magnetometer & Accelerometer sensor: present
- Direction sensor used: rotation vector

Program settings:
-------
- Settings: v9, Count:180
- Set language: de
- System date format: dd.MM.yy
- Time zone: GMT+01:00
- Debug mode active: no
- Last backup: 26. Apr., 22:11
- Routing mode: Walk
- Live map mode: true
- OSM multi-threading: false / threads: 1
- Map: Germany (Offline)
  - Id: cgeo.geocaching.maps.mapsforge.MapsforgeMapProvider$OfflineMapSource:3438-3261:CGeo/maps/germany.map
  - Atts: Map data (c) OpenStreetMap contributors
  - Theme: Elevate.zip:Elevate.xml

Filters:
-------
- Hide waypoints: original visited
- LIVE: _Tour* ([_Tour:inconclusive=false:advanced=true]AND(status:exclude_disabled:exclude_archived))
- OFFLINE: Keine ([:inconclusive=false:advanced=false]AND(type;difficulty_terrain:d=-:d=-:t=-:t=-;status))

Stored Filters (#15):
- _Standard: [_Standard:inconclusive=false:advanced=false]AND(status:found_no:exclude_archived))
- _Test: [_Test:inconclusive=false:advanced=true]AND(difficulty_terrain:d=1.5:d=4.0:t=-:t=3.0))
- _toSolve: [_toSolve:inconclusive=false:advanced=true]AND(type:MYSTERY;status:solved_mystery_no))
- _Tour: [_Tour:inconclusive=false:advanced=false]AND(status:found_no:has_offline_found_log_no:solved_mystery_yes:exclude_disabled:exclude_archived))
- _unsaved: [_unsaved:inconclusive=false:advanced=false]AND(status:found_no:exclude_archived;stored_since:-10:-10))
- Events: [Events:inconclusive=false:advanced=false]AND(hidden:2021-09-21:-:false:-1:-1;type:EVENT))
- hasTrackable: [hasTrackable:inconclusive=false:advanced=true]AND(status:has_trackable_yes))
- LabStation: [LabStation:inconclusive=false:advanced=false]AND(note::is_present;type:USER_DEFINED:ADVLAB;status))
- Offlinelog: [Offlinelog:inconclusive=false:advanced=true]AND(status:has_offline_found_log_yes))
- Steffen: [Steffen:inconclusive=false:advanced=true]AND(status:found_no:has_offline_found_log_no;stored_list:122:31))
- toLog_Bianca: [toLog_Bianca:inconclusive=false:advanced=false]AND(stored_list:86;status:found_yes;log_entry:biansch :contains:inverse=true:logtext=:logtext=contains))
- toLog_Carolin: [toLog_Carolin:inconclusive=false:advanced=false]AND(stored_list:86;status:found_yes;log_entry:carosch:contains:inverse=true:logtext=:logtext=contains))
- Umlaute: [Umlaute:inconclusive=false:advanced=true]OR(note:+29:contains;note:+28:contains;note:+27:contains))
- winter: [winter:inconclusive=false:advanced=true]AND(attributes:winter_no:inverse=true:attributesources=3))
- WithNotes: [WithNotes:inconclusive=false:advanced=true]AND(note::is_present))

Services:
-------
- Geocaching sites enabled:
   geocaching.com: Logged in (Anmeldung OK) / PREMIUM
   Geocaching.com Adventure Lab
   opencaching.de: Logged in (Anmeldung OK)
- Geocaching.com date format: dd MMM yy
- Geocaching.com website language: en-US
- Last login error on geocaching.com: communication error (2022-11-15 15-58)
- Last successful login on geocaching.com: 2022-11-18 13-15
- Routing: internal / BRouter installed: false
- Installed c:geo plugins:  none

Permissions & paths:
-------
- Fine location permission: granted
- Write external storage permission: granted
- System internal c:geo dir: /data/user/0/cgeo.geocaching (68,0 GB free) v3 internal isDir(8 entries)
- Legacy User storage c:geo dir: /data/user/0/cgeo.geocaching (68,0 GB free) v3 internal isDir(8 entries)
- Geocache data: /storage/emulated/0/Android/data/cgeo.geocaching/files/GeocacheData (68,0 GB free) v3 external non-removable isDir(1748 entries)
- Internal theme sync (is turned off): /data/user/0/cgeo.geocaching/MapThemeData (68,0 GB free) v3 internal isDir(0 entries)
- Public Folders: #12
  - BASE: SD-Karte/CGeo (User-Defined)[SD-Karte/CGeo[DOCUMENT#0:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo, Av:true, files:>=21, dirs:>=9, totalFileSize:>=6,7 GB, free space: 100,1 GB, files on device: 0)
  - OFFLINE_MAPS: SD-Karte/CGeo/maps (Default)[SD-Karte/CGeo/maps[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/maps]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Fmaps, Av:true, files:10, dirs:2, totalFileSize:6,7 GB, free space: 100,1 GB, files on device: 0)
  - OFFLINE_MAP_THEMES: SD-Karte/CGeo/maps/_themes (Default)[SD-Karte/CGeo/maps/_themes[PERSISTABLE_FOLDER(OFFLINE_MAPS)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/maps/_themes]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Fmaps%2F_themes, Av:true, files:2, dirs:0, totalFileSize:468,1 KB, free space: 100,1 GB, files on device: 0)
  - OFFLINE_MAP_SHADING: SD-Karte/CGeo/maps/_hgt (Default)[SD-Karte/CGeo/maps/_hgt[PERSISTABLE_FOLDER(OFFLINE_MAPS)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/maps/_hgt]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Fmaps%2F_hgt, Av:true, files:0, dirs:0, totalFileSize:0 B, free space: 100,1 GB, files on device: 0)
  - LOGFILES: SD-Karte/CGeo/logfiles (Default)[SD-Karte/CGeo/logfiles[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/logfiles]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Flogfiles, Av:true, files:1, dirs:0, totalFileSize:72,7 KB, free space: 100,1 GB, files on device: 0)
  - GPX: SD-Karte/CGeo/gpx (Default)[SD-Karte/CGeo/gpx[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/gpx]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Fgpx, Av:true, files:10, dirs:0, totalFileSize:76,4 MB, free space: 100,1 GB, files on device: 0)
  - BACKUP: SD-Karte/CGeo/backup (Default)[SD-Karte/CGeo/backup[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/backup]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Fbackup, Av:true, files:>=10, dirs:>=10, totalFileSize:>=253,8 MB, free space: 100,1 GB, files on device: 0)
  - FIELD_NOTES: SD-Karte/CGeo/field-notes (Default)[SD-Karte/CGeo/field-notes[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/field-notes]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Ffield-notes, Av:true, files:4, dirs:0, totalFileSize:8,4 KB, free space: 100,1 GB, files on device: 0)
  - SPOILER_IMAGES: SD-Karte/CGeo/GeocachePhotos (Default)[SD-Karte/CGeo/GeocachePhotos[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/GeocachePhotos]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2FGeocachePhotos, Av:true, files:>=2, dirs:>=37, totalFileSize:>=5,2 MB, free space: 100,1 GB, files on device: 0)
  - ROUTING_BASE: SD-Karte/CGeo/routing (Default)[SD-Karte/CGeo/routing[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/routing]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Frouting, Av:true, files:9, dirs:1, totalFileSize:340,3 MB, free space: 100,1 GB, files on device: 0)
  - ROUTING_TILES: SD-Karte/CGeo/routing/segments4 (Default)[SD-Karte/CGeo/routing/segments4[PERSISTABLE_FOLDER(ROUTING_BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/routing/segments4]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Frouting%2Fsegments4, Av:true, files:2, dirs:0, totalFileSize:340,2 MB, free space: 100,1 GB, files on device: 0)
  - TEST_FOLDER: [Legacy]/data/user/0/cgeo.geocaching/files/unittest (Default)[/data/user/0/cgeo.geocaching/files/unittest[FILE#1:p-file:///data/user/0/cgeo.geocaching/files::/unittest]] (Uri: file:///data/user/0/cgeo.geocaching/files/unittest, Av:true, files:0, dirs:0, totalFileSize:0 B, free space: 68,0 GB, files on device: -1)
- Map render theme path: Elevate.zip:Elevate.xml
- PersistedDocumentUris: #1
- UNUSED_TRACK: null
- Persisted Uri Permissions: #1
  - content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo (1. Apr., 19:00):RW
- Database: /data/user/0/cgeo.geocaching/databases/data (v99, Size:99,2 MB) on system internal storage

--- End of system information ---
## System information

c:geo version: 2022.11.16-NB-c66e387

Device:
-------
- Device type: SM-G980F (x1sxx, samsung)
- Available processors: 8
- Android version: 11
- Android build: RP1A.200720.012.G980FXXSCDUJ5
- Screen resolution: 1080x2178px (360x726dp)
- Pixel density: 3.3000002
- System font scale: 1.1 / used scale: 1.1
- Sailfish OS detected: false
- Google Play services: enabled - 22.44.17 (150408-488410709)

Sensor and location:
-------
- Low power mode: active
- Compass capabilities: yes
- Rotation vector sensor: present
- Orientation sensor: present
- Magnetometer & Accelerometer sensor: present
- Direction sensor used: rotation vector

Program settings:
-------
- Settings: v9, Count:180
- Set language: de
- System date format: dd.MM.yy
- Time zone: GMT+01:00
- Debug mode active: no
- Last backup: 26. Apr., 22:11
- Routing mode: Walk
- Live map mode: true
- OSM multi-threading: false / threads: 1
- Map: Germany (Offline)
  - Id: cgeo.geocaching.maps.mapsforge.MapsforgeMapProvider$OfflineMapSource:3438-3261:CGeo/maps/germany.map
  - Atts: Map data (c) OpenStreetMap contributors
  - Theme: Elevate.zip:Elevate.xml

Filters:
-------
- Hide waypoints: original visited
- LIVE: _Tour* ([_Tour:inconclusive=false:advanced=true]AND(status:exclude_disabled:exclude_archived))
- OFFLINE: Keine ([:inconclusive=false:advanced=false]AND(type;difficulty_terrain:d=-:d=-:t=-:t=-;status))

Stored Filters (#15):
- _Standard: [_Standard:inconclusive=false:advanced=false]AND(status:found_no:exclude_archived))
- _Test: [_Test:inconclusive=false:advanced=true]AND(difficulty_terrain:d=1.5:d=4.0:t=-:t=3.0))
- _toSolve: [_toSolve:inconclusive=false:advanced=true]AND(type:MYSTERY;status:solved_mystery_no))
- _Tour: [_Tour:inconclusive=false:advanced=false]AND(status:found_no:has_offline_found_log_no:solved_mystery_yes:exclude_disabled:exclude_archived))
- _unsaved: [_unsaved:inconclusive=false:advanced=false]AND(status:found_no:exclude_archived;stored_since:-10:-10))
- Events: [Events:inconclusive=false:advanced=false]AND(hidden:2021-09-21:-:false:-1:-1;type:EVENT))
- hasTrackable: [hasTrackable:inconclusive=false:advanced=true]AND(status:has_trackable_yes))
- LabStation: [LabStation:inconclusive=false:advanced=false]AND(note::is_present;type:USER_DEFINED:ADVLAB;status))
- Offlinelog: [Offlinelog:inconclusive=false:advanced=true]AND(status:has_offline_found_log_yes))
- Steffen: [Steffen:inconclusive=false:advanced=true]AND(status:found_no:has_offline_found_log_no;stored_list:122:31))
- toLog_Bianca: [toLog_Bianca:inconclusive=false:advanced=false]AND(stored_list:86;status:found_yes;log_entry:biansch :contains:inverse=true:logtext=:logtext=contains))
- toLog_Carolin: [toLog_Carolin:inconclusive=false:advanced=false]AND(stored_list:86;status:found_yes;log_entry:carosch:contains:inverse=true:logtext=:logtext=contains))
- Umlaute: [Umlaute:inconclusive=false:advanced=true]OR(note:+29:contains;note:+28:contains;note:+27:contains))
- winter: [winter:inconclusive=false:advanced=true]AND(attributes:winter_no:inverse=true:attributesources=3))
- WithNotes: [WithNotes:inconclusive=false:advanced=true]AND(note::is_present))

Services:
-------
- Geocaching sites enabled:
   geocaching.com: Logged in (Anmeldung OK) / PREMIUM
   Geocaching.com Adventure Lab
   opencaching.de: Logged in (Anmeldung OK)
- Geocaching.com date format: dd MMM yy
- Geocaching.com website language: en-US
- Last login error on geocaching.com: communication error (2022-11-15 15-58)
- Last successful login on geocaching.com: 2022-11-18 13-15
- Routing: internal / BRouter installed: false
- Installed c:geo plugins:  none

Permissions & paths:
-------
- Fine location permission: granted
- Write external storage permission: granted
- System internal c:geo dir: /data/user/0/cgeo.geocaching (68,0 GB free) v3 internal isDir(8 entries)
- Legacy User storage c:geo dir: /data/user/0/cgeo.geocaching (68,0 GB free) v3 internal isDir(8 entries)
- Geocache data: /storage/emulated/0/Android/data/cgeo.geocaching/files/GeocacheData (68,0 GB free) v3 external non-removable isDir(1748 entries)
- Internal theme sync (is turned off): /data/user/0/cgeo.geocaching/MapThemeData (68,0 GB free) v3 internal isDir(0 entries)
- Public Folders: #12
  - BASE: SD-Karte/CGeo (User-Defined)[SD-Karte/CGeo[DOCUMENT#0:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo, Av:true, files:>=21, dirs:>=9, totalFileSize:>=6,7 GB, free space: 100,1 GB, files on device: 0)
  - OFFLINE_MAPS: SD-Karte/CGeo/maps (Default)[SD-Karte/CGeo/maps[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/maps]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Fmaps, Av:true, files:10, dirs:2, totalFileSize:6,7 GB, free space: 100,1 GB, files on device: 0)
  - OFFLINE_MAP_THEMES: SD-Karte/CGeo/maps/_themes (Default)[SD-Karte/CGeo/maps/_themes[PERSISTABLE_FOLDER(OFFLINE_MAPS)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/maps/_themes]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Fmaps%2F_themes, Av:true, files:2, dirs:0, totalFileSize:468,1 KB, free space: 100,1 GB, files on device: 0)
  - OFFLINE_MAP_SHADING: SD-Karte/CGeo/maps/_hgt (Default)[SD-Karte/CGeo/maps/_hgt[PERSISTABLE_FOLDER(OFFLINE_MAPS)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/maps/_hgt]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Fmaps%2F_hgt, Av:true, files:0, dirs:0, totalFileSize:0 B, free space: 100,1 GB, files on device: 0)
  - LOGFILES: SD-Karte/CGeo/logfiles (Default)[SD-Karte/CGeo/logfiles[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/logfiles]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Flogfiles, Av:true, files:1, dirs:0, totalFileSize:72,7 KB, free space: 100,1 GB, files on device: 0)
  - GPX: SD-Karte/CGeo/gpx (Default)[SD-Karte/CGeo/gpx[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/gpx]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Fgpx, Av:true, files:10, dirs:0, totalFileSize:76,4 MB, free space: 100,1 GB, files on device: 0)
  - BACKUP: SD-Karte/CGeo/backup (Default)[SD-Karte/CGeo/backup[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/backup]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Fbackup, Av:true, files:>=10, dirs:>=10, totalFileSize:>=253,8 MB, free space: 100,1 GB, files on device: 0)
  - FIELD_NOTES: SD-Karte/CGeo/field-notes (Default)[SD-Karte/CGeo/field-notes[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/field-notes]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Ffield-notes, Av:true, files:4, dirs:0, totalFileSize:8,4 KB, free space: 100,1 GB, files on device: 0)
  - SPOILER_IMAGES: SD-Karte/CGeo/GeocachePhotos (Default)[SD-Karte/CGeo/GeocachePhotos[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/GeocachePhotos]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2FGeocachePhotos, Av:true, files:>=2, dirs:>=37, totalFileSize:>=5,2 MB, free space: 100,1 GB, files on device: 0)
  - ROUTING_BASE: SD-Karte/CGeo/routing (Default)[SD-Karte/CGeo/routing[PERSISTABLE_FOLDER(BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/routing]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Frouting, Av:true, files:9, dirs:1, totalFileSize:340,3 MB, free space: 100,1 GB, files on device: 0)
  - ROUTING_TILES: SD-Karte/CGeo/routing/segments4 (Default)[SD-Karte/CGeo/routing/segments4[PERSISTABLE_FOLDER(ROUTING_BASE)#1:p-content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo::/routing/segments4]] (Uri: content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo/document/3438-3261%3ACGeo%2Frouting%2Fsegments4, Av:true, files:2, dirs:0, totalFileSize:340,2 MB, free space: 100,1 GB, files on device: 0)
  - TEST_FOLDER: [Legacy]/data/user/0/cgeo.geocaching/files/unittest (Default)[/data/user/0/cgeo.geocaching/files/unittest[FILE#1:p-file:///data/user/0/cgeo.geocaching/files::/unittest]] (Uri: file:///data/user/0/cgeo.geocaching/files/unittest, Av:true, files:0, dirs:0, totalFileSize:0 B, free space: 68,0 GB, files on device: -1)
- Map render theme path: Elevate.zip:Elevate.xml
- PersistedDocumentUris: #1
- UNUSED_TRACK: null
- Persisted Uri Permissions: #1
  - content://com.android.externalstorage.documents/tree/3438-3261%3ACGeo (1. Apr., 19:00):RW
- Database: /data/user/0/cgeo.geocaching/databases/data (v99, Size:99,2 MB) on system internal storage

--- End of system information ---

Additional Information

Screenshot_20221118-141453_cgeo

Generated waypoints are shown on the map, if they were "really" created and not only temporary for the map

@eddiemuc
Copy link
Contributor

confirmed

@eddiemuc eddiemuc self-assigned this Nov 19, 2022
@eddiemuc
Copy link
Contributor

I looked into this. The problem is as follows:

  • to display the generated waypoint, I create a temporary, transient cache in code which has no coordinate. I attach the generated waypoints to this cache and use the map's "display cache" function to display it
  • Looking into the code of the map, I see that now that cache's waypoints are no longer displayed if the cache itself has no coordinate. This is why the function does not work

The clean way to handle this would be to add a function to the map to display multiple waypoints (it already has a function to display a single waypoint).

However, I restrain from this since the map itself is currently undergoind major refactoring (Unified map), and it might be best to wait until this is concluded.

So I am unsure how to proceed here. Should I remove the function for the time being?
(I also tried to give the temporary cache a coordinate, but this leads to follow-up strange/buggy behaviour if the user e.g. clicks this cache on the map and requests details (will fail) or stores it offline (will be successful, but later in list opening of it will fail))

@eddiemuc eddiemuc removed their assignment Nov 20, 2022
@Lineflyer
Copy link
Member

Looking into the code of the map, I see that now that cache's waypoints are no longer displayed if the cache itself has no coordinate. This is why the function does not work

The question would IMHO be, why this was changed (I assume it was changed as the feature was working before). Maybe it was an unintentional change which can be reverted.

Otherwise I do somehow agree, that huge changes to the current map implementations are probably not the best way while refactoring is ongoing.

@Lineflyer Lineflyer added the Bug Issues classified as a bug label Nov 21, 2022
@murggel
Copy link
Contributor Author

murggel commented Nov 21, 2022

I could live in the meantime with generating and deleting the waypoints to show them on the map. If no one else reported the problem....

@eddiemuc
Copy link
Contributor

Looking into the code of the map, I see that now that cache's waypoints are no longer displayed if the cache itself has no coordinate. This is why the function does not work

The question would IMHO be, why this was changed (I assume it was changed as the feature was working before). Maybe it was an unintentional change which can be reverted.

To be honest, I don't understand this myself. The code I looked at which filters out caches with null coordinates seems to be there already for a long time. Frenkly, I can't tell why this worked before...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues classified as a bug
Projects
None yet
Development

No branches or pull requests

3 participants