Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash screen problems #13701

Open
Lineflyer opened this issue Nov 20, 2022 · 15 comments
Open

Splash screen problems #13701

Lineflyer opened this issue Nov 20, 2022 · 15 comments
Labels
Bug Issues classified as a bug

Comments

@Lineflyer
Copy link
Member

    Offtopic:

Why is our logo that unaligned at the splash screen?

Screenshot_20221118_085021

Originally posted by @fm-sys in #13640 (comment)

@Lineflyer
Copy link
Member Author

While I think the above looks more or less correct, on my Android 13 device it now looks like this (could not make a screenshot in time, so its a video of the device :) ):

VID_20221120_115241.mp4

@moving-bits
Copy link
Member

We should probably revert #13650 as it seems to have those unwanted side-effects and also does not solve the related lint finding, even though I followed the migration docs on developer.android.com

@Lineflyer Lineflyer added the Bug Issues classified as a bug label Nov 21, 2022
@Lineflyer
Copy link
Member Author

If we want to go for another beta rather soon, we should revert. Otherwise feel free to "play around" and fix if you might have any idea.

@moving-bits
Copy link
Member

Regarding the initial question:

Why is our logo that unaligned at the splash screen?

We are currently using splashscreen_background as drawable for the splash screen, which uses a transparent background and the following image:

image

This does at least explain the off-center look, especially if the system decides to not show the original squared image but a circled subset of it.

@bekuno
Copy link
Member

bekuno commented Nov 21, 2022

I created a separate Issue for the second problem with the false image size.

For the original issue - my spash image is:
Screenshot_20221120-150734_cgeo 3

Also in square format is the "box" not good centered.

@moving-bits
Copy link
Member

Strange observation: If I move the file splash_screen.png from its current folder res/drawable-ldpi to res/drawable-xhdpi (to avoid some unwanted upscaling of the png), it displays our regular square, without circle around it. 🤔

BTW @ztNFny: Do we still have a XML (SVG-based) version of this logo?
(I could only find the map background xml file ic_launcher_background.xml, but not the green box.)

@ztNFny
Copy link
Contributor

ztNFny commented Nov 21, 2022

BTW @ztNFny: Do we still have a XML (SVG-based) version of this logo?
(I could only find the map background xml file ic_launcher_background.xml, but not the green box.)

There's no XML version as XML doesn't support those shadows. SVG is at https://github.com/cgeo/cgeo/blob/master/main/project/rawimages/ic_launcher_foreground.svg

@bekuno
Copy link
Member

bekuno commented Nov 21, 2022

See #10522 (comment)

@fm-sys
Copy link
Member

fm-sys commented Nov 21, 2022

I would vote to drop the shadow and go with a pure SVG launcher icon. Shadows are kinda last decade anyway ;-)

@ztNFny
Copy link
Contributor

ztNFny commented Nov 21, 2022

I would vote to drop the shadow and go with a pure SVG launcher icon. Shadows are kinda last decade anyway ;-)

That's not an option imho - it looks quite unrefined. It's not the drop shadow that's not supported but the smaller gradients, e.g. around the "c:geo" text.

image

@fm-sys
Copy link
Member

fm-sys commented Nov 21, 2022

Current Pure SVG
grafik grafik

Images taken from #10522

Maybe even remove the background shadow, so that we can properly center the geocaching box inside the launcher icon?

@ztNFny
Copy link
Contributor

ztNFny commented Nov 21, 2022

actually with the latest Android Studio version this is vector image generated from SVG:
image

Completely broken ...

@Lineflyer
Copy link
Member Author

Regarding the comparison above:
I could live with the missing gradient/shadow...its displayed on the splash screen for some seconds at max.

@ztNFny
Copy link
Contributor

ztNFny commented Nov 21, 2022

after some cleanup of the input svg and slight tweaks to the generated vector:

image

@fm-sys
Copy link
Member

fm-sys commented Nov 21, 2022

actually with the latest Android Studio version this is vector image generated from SVG: [...]

Completely broken ...

No body wants to use the broken version but the working one. Your last version looks good 👍

Just messured: The icon is displayed at 10x10mm on the user's home screen. The gradient is 100% invisible on that size anyway. And even at larger size, the version without gradients looks IMHO way cleaner. (We can discuss whether we want to remove the strange yellow dot at the front corner completely)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues classified as a bug
Projects
None yet
Development

No branches or pull requests

5 participants