Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login issues and other website problems for c:geo (master ticket) #15555

Open
6 of 7 tasks
moving-bits opened this issue Apr 5, 2024 · 38 comments
Open
6 of 7 tasks

Login issues and other website problems for c:geo (master ticket) #15555

moving-bits opened this issue Apr 5, 2024 · 38 comments
Labels
Bug Issues classified as a bug Prio - High A significant malfunction of a feature/function. High user impact. Regression An exitsting function/feature does no longer work as expected.

Comments

@moving-bits
Copy link
Member

moving-bits commented Apr 5, 2024 •
edited

This issue serves as a master ticket for current issues for c:geo due to the recent website changes. Bookmark this page for a status overview on progress. Issues marked as "closed" are fixed and will be released with the next nightly version / developer build. We will notify you here when a general public release is published.

Known issues due to recent website changes:
@moving-bits moving-bits added Bug Issues classified as a bug Prio - High A significant malfunction of a feature/function. High user impact. Regression An exitsting function/feature does no longer work as expected. labels Apr 5, 2024
@moving-bits moving-bits pinned this issue Apr 5, 2024
@moving-bits
Copy link
Member Author

moving-bits commented Apr 5, 2024 •
edited by Lineflyer

Will start building an interim bugfix release now, including the login fix (but no TB fixes yet, those will take some more time).

  • Check/insert correct version name in BranchDetectionHelper.java
  • Wait for a Crowdin cycle or trigger sync manually
  • Merge the related Crowdin translation pull requests for branch release
  • Build release on CI server
  • Perform smoke test with resulting cgeo-release.apk before continuing
  • Upload and publish cgeo-release.apk to Google Play
  • Tag the release on Github in format market_yyyymmdd
  • Publish the release on Github including upload of cgeo-release.apk to Github
  • Publish release on F-Droid
  • Trigger notification to status.cgeo.org via CI server
  • Post release info to Facebook
  • Post release info to Twitter/X

@Lineflyer
Copy link
Member

Perfect! Thanks!

@moving-bits
Copy link
Member Author

Release 2024.04.05 is rolling, should be available on Play Store in an hour or so, and earlier on F-Droid or via direct download.
It includes the login fix (as well as other non-urgent fixes since the last release 2024.03.19).

@Lineflyer
Copy link
Member

Lineflyer commented Apr 5, 2024 •
edited

Thanks @moving-bits

ToDo for this case:

  • Check status.cgeo.org and wait until deployment figures are increasing (=Update is live)
  • Use CI to trigger update notification to inform users to upgrade
  • Use CI to clear custom notification

@realMrTom
Copy link

Seen update in Playstore and installed it. Now I'm logged in correctly as premium and can see (including logs and fotos), save and log caches. Only finding TB's doesn't work. Thanks for this update. I'm glad for no longer being forced to use the officially app.

@moving-bits
Copy link
Member Author

[ ] Use CI to trigger update notification to inform users to upgrade
[ ] Use CI to clear custom notification

Please keep a notification until TB handling is fixed as well.

Update is available meanwhile, I'll trigger the default update notification via CI.

@wolverine007
Copy link

Seen update in Playstore and installed it. Now I'm logged in correctly as premium and can see (including logs and fotos), save and log caches. Only finding TB's doesn't work. Thanks for this update. I'm glad for no longer being forced to use the officially app.

I needed to refresh the cgeo<>GC.com authentication, kill the app and after a fresh start all was fine.

@moving-bits maybe you could add this to the info box?

@bekuno
Copy link
Member

bekuno commented Apr 6, 2024

The automatic connect to GC was fine after the update for me, no aditional work was necessary.

@wolverine007
Copy link

The automatic connect to GC was fine after the update for me, no aditional work was necessary.

Got the same issue from above with two different devices and accounts - login was fine, but Premium was missing

@Lineflyer
Copy link
Member

Thats another issue we already have listed here. PM is only detected after second login. We should really try to fix it to avoid confusion.

@Lineflyer
Copy link
Member

Posted on Facebook

@ztNFny
Copy link
Contributor

ztNFny commented Apr 6, 2024

It seems GC changed (reverted) something on their end. Login works fine again with the old version as of right now.

@eddiemuc
Copy link
Contributor

eddiemuc commented Apr 6, 2024 •
edited

It seems GC changed (reverted) something on their end. Login works fine again with the old version as of right now.

If gc.com reverts it's change then login should still work with my PR for login change adaption. I am unsure about retrieval of "found caches" count though

@MagpieFourtyTwo
Copy link

@eddiemuc

If gc.com reverts it's change then
login should still work (...)
retrieval of "found caches" count (...)

Both WFM right now, with latest nightly.

@technetium
Copy link
Contributor

I can confirm the app updated on my phone, it's logging in at geocaching.com and I can at l(e)ast post a picture at one of my logs. Thank you for your work and the recent update.

@itsbrody
Copy link

itsbrody commented Apr 7, 2024

Since yesterday (afternoon) I can login again; writing (and editing) Logs and sending them. I'm still on build 2024.03.19 and surprised.

@ztNFny
Copy link
Contributor

ztNFny commented Apr 7, 2024

It seems GC changed (reverted) something on their end. Login works fine again with the old version as of right now.

And broken again 😭 Maybe some A/B testing?

@MagpieFourtyTwo
Copy link

@eddiemuc

If gc.com reverts it's change then
login should still work (...)
retrieval of "found caches" count (...)

Both WFM right now, with latest nightly.

Hrmm - found count was at least strange today. But perhaps nevertheless correct WRT c:geo's retrieval ...

Scenario: Have visited some caches this afternoon (between about 15:00 and 17:00) and of course saved offline logs, which I now uploaded as drafts to gc.com. But while writing the first log online, I just noticed that the found counts, c:geo generated with the NUMBER macro this afternoon, where off by 10 caches - which is exactly the number of lab caches I made a few years ago on a MEGA. And which were not counted into the finds count till last week (for whatever reason). But last week I noticed that my found count suddenly jumped up by 10 - after wondering about the reason for a while I thought that GS may have changed their mind about counting event labs now. But today the count seems to have dropped again by 10 ... most probably in the same time slot when the "old" login did work again ... haven't checked the minutes, but if just looking at the hours, it may have been the same time slot. Seems as if there is even more going on behind the scenes ...

Or has anyone else had such experiences? Which, despite everything, could perhaps nevertheless be an indicator of a non-functioning retrieval ...?

@MagpieFourtyTwo
Copy link

Ah, just stumbled upon a commit which claims to have fixed found counter problems ... will just have an eye on it.
Although right now it works correct again ... (just tested with a fake log) ... heieiei. How is one supposed to make sense of the confusion, the pros over there are constantly causing ...?

@technetium
Copy link
Contributor

Unfortunately, yesterday evening I could not log in. Today still not able to login.

p.s. Do you like/want this kind of status updates, or are these annoying remarks keeping you from fixing the problem?

@moving-bits
Copy link
Member Author

Not being able to log in can have several causes. In most cases c:geo shows you some additional info / an error message. The problem mentioned above showed something like "request verification token not found", whereas something like "captcha required" would be some totally different reason, not directly related to the recent website changes.

@Lineflyer
Copy link
Member

We still get some (but not many) reports of users not being able to login ("failed to find request verification token") with version 2024.04.05.
Have seen two users on FB and two users on support.

Not sure whats going on.

@MagpieFourtyTwo
Copy link

MagpieFourtyTwo commented Apr 8, 2024 •
edited

Over here (with latest nightly) it's working - at least most of the times:

  • after a fresh restart, not a single login succeeded within the usual two to three seconds :/
  • most of the times it takes about 25 seconds
  • some take even up to 45 seconds, but are at least successful
  • if longer than 45 secs, they hang for... ok, don't know for how long, cause being on tour I usually killed c:geo after 2 minutes, and afterwards it again takes 25-45 seconds - most of the times ... ;)

Which leads me to a question: What happens if Live Map is started while the login procedure is still active, but has not yet been successful? Seems as if c:geo caches the member state (as it nevertheless indicates Premium), but how about fetching caches? Will this just be delayed or will PM caches be suppressed till login was successful?

@technetium
Copy link
Contributor

Sorry, I had the march version on my phone. Don't know if the app downgraded or if the old version magically worked for a day.
With the last release, it works, but for a long time (minutes) the app stated I was a basic member. In the same period, I could also not update my log from a premium cache.
The things I tried work now.

@itsbrody
Copy link

itsbrody commented Apr 9, 2024

We still get some (but not many) reports of users not being able to login ("failed to find request verification token") with version 2024.04.05. Have seen two users on FB and two users on support.

Not sure whats going on.

whilst with 2024.03.19 version again the above mentioned login error occured, the update to fdroids 2024.04.05-version currently seem to work (as least regards the login problem): I get in an acceptable time of less seconds a "login OK - Premium"

@Lineflyer
Copy link
Member

How to proceed?
Shall we publish another bugfix release to get trackables working again and potential fix for caches outsise visible area on map or is there work in progress?

@moving-bits
Copy link
Member Author

How to proceed? Shall we publish another bugfix release to get trackables working again and potential fix for caches outsise visible area on map or is there work in progress?

I'll update the fix for the yet-again changed find count today and can prepare a new bugfix release (based on release and including that fix) tonight.

@MagpieFourtyTwo
Copy link

the yet-again changed find count

Perhaps you can even figure out why the login takes so extremely long (at least 25 to 30 and sometimes even up to 90 secs)?
Seems to be connected to the new token and found count fetching ...

BTW: Is there actually an end in sight or are there still changes resp. back and forth actions every single day?

@moving-bits
Copy link
Member Author

Perhaps you can even figure out why the login takes so extremely long (at least 25 to 30 and sometimes even up to 90 secs)? Seems to be connected to the new token and found count fetching ...

AFAIK there have no new calls to the server been added, so response time should be unchanged by that (and thus only be influenced by network connection and server responsiveness).

BTW: Is there actually an end in sight or are there still changes resp. back and forth actions every single day?

Seems to have calmed down meanwhile. We still have two failing tests wrt to trackables, but other than that all tests are back to green (and seem to stay at that).

@MagpieFourtyTwo
Copy link

In web browser pages load within fractions of a second, thus server is not an issue over here.
Haven't timed the logins before, but would swear they were way faster before, in fact within no time, too. At least I have never seen the "Logging in" message that long before this change rally started.

@bekuno
Copy link
Member

bekuno commented Apr 13, 2024

Since some day we have new test errors at CI, see #15591.
I added it to the list above.

@moving-bits
Copy link
Member Author

moving-bits commented Apr 13, 2024 •
edited

All tests on CI are back to green meanwhile. Will start preparing a new bugfix release now:

  • Check/insert correct version name in BranchDetectionHelper.java
  • Wait for a Crowdin cycle or trigger sync manually
  • Merge the related Crowdin translation pull requests for branch release
  • Build release on CI server
  • Perform smoke test with resulting cgeo-release.apk before continuing
  • Upload and publish cgeo-release.apk to Google Play
  • Tag the release on Github in format market_yyyymmdd
  • Publish the release on Github including upload of cgeo-release.apk to Github
  • Publish release on F-Droid
  • Trigger notification to status.cgeo.org via CI server
  • Post release info to Facebook
  • Post release info to Twitter/X

@Lineflyer
Copy link
Member

Added #15633 in initial post.

Need a new release once fix is confirmed and merged.

@moving-bits
Copy link
Member Author

moving-bits commented Apr 18, 2024 •
edited by Lineflyer

I'll start preparing a new bugfix release now:

  • Check/insert correct version name in BranchDetectionHelper.java
  • Wait for a Crowdin cycle or trigger sync manually
  • Merge the related Crowdin translation pull requests for branch release
  • Build release on CI server
  • Perform smoke test with resulting cgeo-release.apk before continuing
  • Upload and publish cgeo-release.apk to Google Play
  • Tag the release on Github in format market_yyyymmdd
  • Publish the release on Github including upload of cgeo-release.apk to Github
  • Publish release on F-Droid
  • Trigger notification to status.cgeo.org via CI server
  • Post release info to Facebook
  • Post release info to Twitter/X

@Lineflyer
Copy link
Member

Posted on FB.
Posting on X still not working due to 2FA to a mail address, where I do not have access to.

@moving-bits
Copy link
Member Author

We have relevant new fixes since our last release (2024.04.18), namely the new TB logging fix and the username detection (among other things), thus I propose to release a new bugfix update before the weekend.

@MagpieFourtyTwo
Copy link

BTW: Login is way faster again (since a couple of days), takes usually "just" 5 seconds. Not as fast as "before", but ok. Sometimes still "Login failed" appears, but usually repairs itself after another 5 seconds. And although I had to restart c:geo completely yesterday to get logged in, this happened only once. Thus I would consider login pretty "normal" for now.

@moving-bits
Copy link
Member Author

moving-bits commented Apr 25, 2024 •
edited

Will start working on a new release now:

  • Check/insert correct version name in BranchDetectionHelper.java
  • Wait for a Crowdin cycle or trigger sync manually
  • Merge the related Crowdin translation pull requests for branch release
  • Build release on CI server
  • Perform smoke test with resulting cgeo-release.apk before continuing
  • Upload and publish cgeo-release.apk to Google Play
  • Tag the release on Github in format market_yyyymmdd
  • Publish the release on Github including upload of cgeo-release.apk to Github
  • Publish release on F-Droid
  • Trigger notification to status.cgeo.org via CI server
  • Post release info to Facebook
  • Post release info to Twitter/X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues classified as a bug Prio - High A significant malfunction of a feature/function. High user impact. Regression An exitsting function/feature does no longer work as expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@Lineflyer @ztNFny @technetium @realMrTom @moving-bits @wolverine007 @eddiemuc @MagpieFourtyTwo @itsbrody @bekuno