Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*AuthorizationActivity need to be factorized #5619

Open
kumy opened this issue Apr 1, 2016 · 2 comments
Open

*AuthorizationActivity need to be factorized #5619

kumy opened this issue Apr 1, 2016 · 2 comments
Labels
Refactoring Issues requires code refactoring

Comments

@kumy
Copy link
Member

kumy commented Apr 1, 2016

While working on harmonizing the service connectors, I've found many duplicate code between different type of authentications.

Introduce an AbstractAuthorizationActivity as a parent of:

  • AbstractCredentialsAuthorizationActivity
  • TokenAuthorizationActivity
  • OAuthAuthorizationActivity
    • TwitterAuthorizationActivity
    • OCAuthorizationActivity
@kumy kumy added the Refactoring Issues requires code refactoring label Apr 1, 2016
@Lineflyer
Copy link
Member

@rusdev @kumy Still valid?

@kumy
Copy link
Member Author

kumy commented Apr 1, 2019

Didn't follow the development since a long time, but I doubt things changed in this area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactoring Issues requires code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kumy @Lineflyer