Viewport not correct when starting Map from search results (basic member)

[jonas-koeritz]

Detailed steps causing the problem:

• Search for address
• Select search result
• View cache list
• Select "Map" Icon in the Action Bar to map those results

Actual behavior after performing these steps:

The map is (most of the time) zoomed out to zoom level 0.

Expected behavior after performing these steps:

The map is somewhat centered on the found caches and appropriately zoomed.

Version of c:geo used:

master

Is the problem reproducible for you?

Yes

Other comments and remarks:

This is caused by the code performing the search by center. The results most of the time do not contain reliable coordinates or don't contain any coordinates at all. The layer can not be zoomed to.

I already tested a workaround that creats a Viewport of 1.0x1.0 degrees around the center and invokes the new live map search. The search result contains the necessary coordinates to correctly show the map.

The optimal solution would get the bounding box for the given address (e.g. city/state limits) and search within that box. The live map code could be easily extended to handle the paging.

[jonas-koeritz]

Geocoding with Polygon output, just for my own reference:

https://nominatim.openstreetmap.org/search.php?q=query&polygon_geojson=1&format=json&addressdetails=1

[Lineflyer]

You are refering to a basic member scenario, are you?

[jonas-koeritz]

Yes, this is a basic member scenario.

[moving-bits]

additional information: This seems to happen only if

• you are a GC basic member
• and have GC as your only enabled service

(because as soon as you enable a different service which returns reliable results (eg.: oc.de), map will have something to determine the bounding box)

[moving-bits]

@jonas-koeritz

Have a look at main/src/cgeo/geocaching/address/AddressListAdapter.java: When searching for an address like "Köln" the result lists has geo location information. This is already used for the icon beside the found addresses (which opens a map centered to the address found).

This works by transferring the address to the click listener

viewHolder.mapIcon.setOnClickListener(v -> clickListener.onClickMapIcon(addresses.get(viewHolder.getAdapterPosition())));

which is implemented in main/src/cgeo/geocaching/address/AddressListActivity.java, and there the coordinates of the address are used to center the map:

public void onClickMapIcon(final Address address) {
    DefaultMap.startActivityGeoCode(this, new Geopoint(address.getLatitude(), address.getLongitude()));
    finish();
}

Maybe this principle can be reused by preserving the location info during the search steps, promoting it to the cache list and using it there for centering the map, if there is no cache in the list with reliable coordinates?

[jonas-koeritz]

This looks like a feasible idea. I will give it a shot.

[Lineflyer]

This should be outdated as we now utilize the new search which returns coords also to basic members.