Favorite percentage wrong after posting log with favorite point

[Lineflyer]

Describe the bug:
A user of the beta version contacted us with this screenshot:

It shows 133% favorite percentage.

To Reproduce:
Meanwhile the cache has new logs and the situation changes.
I asked the user to provide more details about when this happend, however I assume the following in this example:

• The cache had § found logs and 3 favorite point (=100%)
• He logged the cache and assigned a favorite point

Actual behavior/state after performing these steps:
The fav count is incremented c:geo internally but obviously the total find count is not updated c:geo internally. This would lead to 4 favorite point but still only 3 total finds (=133%)

Expected behavior/state after performing these steps:
The total find count should also be incremented c:geo internally once a user posts a log of type "Found it".

Version of c:geo used:
2019.08.01-RC

Is the problem reproducible:
Difficult to check

@okainov

[Lineflyer]

I was able to reproduce this (and also another used contacted us with a proof).

Example:

• Cache has 4 found logs and 4 favorite points. c:geo shows 100% favorite percentage.
• Log this cache as found and award a favorite point

Result:
Directly after sending the log c:geo shows 5 favorite points and the percentage is 125%
Only after refreshing the cache the percentage is correct = 100% again

Conclusion:
When posting the log the amount of favorite points gets updated locally in the database but seemingly not the number of total finds. This is corrected by refresh as we parse the new number of total found logs in that case.
Fix would IMHO be to increase the number of total finds also locally if a found log is posted with c:geo.

In case of a high number of founds this problem is almost not noticeable as the difference is not so huge. But especially for a cache with a low number of finds this produces a large error.

[bekuno]

I would instead not update the local value. So it stays consistent to the cache update state.

[Lineflyer]

Thats IMHO a bad idea because not teccie users expect to see a change after they gave a favorite point.

Years ago the log was not shown after sending it, only after refresh. That was also not what users expect.

[bekuno]

Is there a reason that we do not refresh the cache automatic directly after the online log?