"Remove all" from List should not delete offline logs without confirmation

[JeanFred]

Here was my situation: I had a huge backlog of caches with offline logs, and I was going through them (via All caches > Filter by > With personal data > With offline logs) to clean them (via Select mode + Clear offline logs [which requires a confirmation]).

I’m not exactly sure how, but I ended up hitting the “Remove all” with no selection − which ended up removing all caches, and their offline logs. ^_^"

Describe the solution you'd like
c-geo should require confirmation when “Removing all” caches with offline logs.

Describe alternatives you've considered
Alternatively, c-geo could not clear offline logs when removing caches from lists (but that does sound a bit counter-intuitive)

Additional context
#3283 & #4251 deal with treating “Clear offline logs” as 'dangerous' option which requires confirmation.

[Lineflyer]

That should not happen as you describe. I just tested it with a different result:

• Have list with offline logged caches
• Delete all caches from this list
• Open "History" list
• All offline logs still present

[JeanFred]

Thanks for investigating this!

Hmmm, additional context which might be relevant: I had over 3100 caches in “All caches”. Some of these offline logs were probably close to 1 year old, the most recent ones 1 month old. My “History” list currently has 245 caches (the top-one visited 2 months ago, the bottom one visited 7 years ago), and none of the now-gone offline logs.

(I’m running c-geo 2019-10-05)

[JeanFred]

(Also, something I wanted to mention in my original report and forgot: to be absolutely clear I don’t blame c-geo for my misadventure here − it was my own fault for having such a backlog, and for mis-operating :-). [That’s also the reason why I filed this as “Enhancement” rather than “bug” :-)])

[Lineflyer]

From what list did you select to "Remove all"?

[JeanFred]

From what list did you select to "Remove all"?

A selection from All caches:

All caches > Filter by > With personal data > With offline logs

[andrixnet]

I had the same thing happen to me this spring at Berlin giga :-(

[Lineflyer]

Looking through issue least recently updated with label "Unverified":

Assigning myself to retest this as time permits.