This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Switch to ethereum-cryptography #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@frangio No don't worry about that. Thanks so much for this. |
|
@frangio You don't have other PRs you're sending here today do you? If not I will publish. |
|
No, unless you have another suggestion for a similar change. I noticed there is also a |
|
It looks to me like sha1 is pure js.... I think this PR is sufficient and will be a big improvement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is currently using an old version of ethereumjs-util (v6 while latest is v7). This version has the downside that it uses native dependencies, which is no longer necessary with modern libraries.
This PR replaces ethereumjs-util with ethereum-cryptography.
Am I supposed to include an updated version of the
mockdirectory?