Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when --parallel flag is used #219

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

cgewecke
Copy link
Owner

@cgewecke cgewecke commented Mar 15, 2024

#218

This logic used to be inside TASK_TEST, so it needed to runSuper(). An error is thrown if there's no override.

Simply returning could be an issue for anyone who wants to override the reporter tasks.

Warning is displayed correctly now:

>>>>> WARNING (hardhat-gas-reporter plugin) <<<<<<
Gas reporting has been skipped because plugin `hardhat-gas-reporter` does not support the --parallel flag.
>>>>>>>>>>>>>>>>>>>>

@cgewecke cgewecke merged commit 1fc633e into master Mar 15, 2024
3 checks passed
@cgewecke cgewecke deleted the fix-run-super-bug branch March 15, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant