Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title disappears on experimental button #55

Closed
linickx opened this issue Sep 5, 2021 · 3 comments · Fixed by #56
Closed

Title disappears on experimental button #55

linickx opened this issue Sep 5, 2021 · 3 comments · Fixed by #56
Labels
bug Something isn't working T-Shirt-Size: S

Comments

@linickx
Copy link

linickx commented Sep 5, 2021

Hello,

The new on/off icons is cool! Is it just me that the title vanishes when the icon toggles?

Off:
image

On:
image

Domain: Light
Service: Toggle

Title cleared, custom set to friendly name.

image

(Default Settings act the same)

Icons used are from material design: Bulb-Outline & Bulb-on.

@cgiesche
Copy link
Owner

cgiesche commented Sep 5, 2021

Hi,

i can reproduce this issue. It seems like StreamDeck ignores the "setTitle" command, when the icon state is set to 1 (on). Debugging output shows, that my plugin sets the title in both cases:

Switching off:
image

Switching on:
image

I will take a closer look, but I think this issue may be "unfixable" (from plugin side of view).

@cgiesche
Copy link
Owner

cgiesche commented Sep 5, 2021

Hmm, second look:
image
Suddenly, a suspicious "state: 0" appears in setTitle call, when state should be 1...

@linickx
Copy link
Author

linickx commented Sep 7, 2021

Hi @cgiesche - Can confirm this is fixed in 1.5.1 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working T-Shirt-Size: S
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants