Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fixes and cleanup. #16

Merged
merged 11 commits into from
May 13, 2014
Merged

bug fixes and cleanup. #16

merged 11 commits into from
May 13, 2014

Commits on Apr 28, 2014

  1. Code cleanup for clarity. 

    * added braces to single line conditionals
* removed redundant argument to count() when already in closure
* tweaked some comments
    @adam-zethraeus
    adam-zethraeus committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    c1e430d View commit details
    Browse the repository at this point in the history

  2. broke out character truncation tests for clarity

    @adam-zethraeus
    adam-zethraeus committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    8d0b499 View commit details
    Browse the repository at this point in the history

  3. removed count argument that dupes closure value

    @adam-zethraeus
    adam-zethraeus committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    e63bdee View commit details
    Browse the repository at this point in the history

  4. Fix for Zero word bug inc. test. Clearer semantic separation of char … 

    …and word count work
    @adam-zethraeus
    adam-zethraeus committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    1df2bac View commit details
    Browse the repository at this point in the history

  5. broke apart count() from isAtLimit() check

    @adam-zethraeus
    adam-zethraeus committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    decd1f6 View commit details
    Browse the repository at this point in the history

  6. moved options type state into the options object

    @adam-zethraeus
    adam-zethraeus committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    6fffb1c View commit details
    Browse the repository at this point in the history

  7. added tests for tagless input

    @adam-zethraeus
    adam-zethraeus committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    c42b6b1 View commit details
    Browse the repository at this point in the history

  8. more state clarity

    @adam-zethraeus
    adam-zethraeus committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    2e3da65 View commit details
    Browse the repository at this point in the history

  9. single setup for trackedState, comment changes

    @adam-zethraeus
    adam-zethraeus committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    49d67ff View commit details
    Browse the repository at this point in the history

  10. fix for trailing tags in zero word case

    @adam-zethraeus
    adam-zethraeus committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    ecdce0c View commit details
    Browse the repository at this point in the history

  11. Fixed trailing tags issue in characters mode. 

    * removed characters + 1 hack
* switched order of limit check and character addition
* introduced one bit of weirdness requiring spaces after final word to be trimmed - but this should be solvable and i judge it worth it for the fixes of above edge cases in functionality and behaviour!
    @adam-zethraeus
    adam-zethraeus committed Apr 28, 2014
    Configuration menu
    Copy the full SHA
    129dd10 View commit details
    Browse the repository at this point in the history