Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system to maintain initial image #13

Closed
adam-zethraeus opened this issue Mar 5, 2014 · 10 comments
Closed

system to maintain initial image #13

adam-zethraeus opened this issue Mar 5, 2014 · 10 comments

Comments

@adam-zethraeus
Copy link
Contributor

What do you think would be a good API to preserve an initial image in the HTML?

downsize("", {words:0, keepInitialImage:true});

@adam-zethraeus
Copy link
Contributor Author

I'm going to start work on this today or tomorrow since it seems to be a blocker for merging anything new into ghost.

@cgiffard
Copy link
Owner

cgiffard commented Mar 6, 2014

Sorry, I've been flat out. I'll have a think about the best way to tackle this tonight — let me know if you get started on it, so we don't end up double-handling. :)

@ErisDS
Copy link

ErisDS commented Apr 27, 2014

Bump :) Would looove for this to be resolved even if it's just a temporary workaround with the condition that I remove it when Ghost no longer needs it 😉

@adam-zethraeus
Copy link
Contributor Author

i'll take another look shortly.

@adam-zethraeus
Copy link
Contributor Author

next on my plate if the cleanup (#16) goes in! :)

@adam-zethraeus
Copy link
Contributor Author

It looks like the two cases this would have to deal with are markdown output matching:

<p><img src="..." ...></p>
and
<p><a href="#"><img src=".."></a></p>

@ErisDS
Copy link

ErisDS commented May 1, 2014

It currently works for video as well I believe.

@adam-zethraeus
Copy link
Contributor Author

oh good point, thanks!

@cgiffard
Copy link
Owner

I want to extend the parser to support tag types rather than regex it. If we merge this we should have a followup to do it properly. :)

@ErisDS
Copy link

ErisDS commented Aug 23, 2014

I think you can close this issue now. I have a plan to reproduce this feature inside Ghost, so that we can upgrade to a newer version of downsize. I don't think it's really the job of downsize to maintain what was a bug.

Also, by having it internally in Ghost, we can properly manage deprecating it once we have equivalent functionality done in the right way.

@cgiffard cgiffard closed this as completed Sep 2, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants