JSHint cleanup #125
JSHint cleanup #125
Conversation
|
Yep. The test encapsulation of JSHint dates to a time where JSHint had a really rubbish CLI. Now, it's fine. :) |
|
All right, I'll update the PR and ping you. |
|
@cgiffard: updated. Let me know if you need something else. https://github.com/cgiffard/node-simplecrawler/pull/125/files?w=1 PS.
|
|
There are a couple of tiny stylistic things that I wanna tweak with the array literal syntax, but other than that, looks good! I'm really tired so I'll do a manual merge in the morning. :) |
|
I've used JSCS and it'd be cool to get it integrated to ensure contributors' style is correct. I might have a crack at it tomorrow (unless you get to it first!) |
Do you mean in this patch or in general?
Should be easy to add it so I might have some time to make a PR later, after this is merged. |
|
Allright, I'm done for now. I used the JSHint rules you see in this PR and ESLint. Would be nice to have this automated but I'll leave it up to you after this is merged. |
| @@ -34,8 +42,9 @@ crawler.emit = function(name, queueItem) { | |||
| return string; | |||
| } | |||
|
|
|||
| if (!~boringEvents.indexOf(name)) | |||
| if (!~boringEvents.indexOf(name)) { | |||
|
@cgiffard: bump for feedback. |
Also, clean up JSHint options and make them stricter.
Used JSHint and ESLint; fixed all JSHint issues, most ESLint ones.
[ci skip]
|
Cleaning up old PRs — going to do a bit of a code cleanup soon, so I figured I'd close this one for now. |
|
I could rebase if needed since I've done the work already.
|
|
Sure, I did a quick review and it looks good. If you're happy to rebase, I'll merge! |
|
There's definitely style stuff there that could evolve, but my feelings on this have mellowed — I think it's more important to be consistent than right. |
|
Rebased this but apparently you have closed it. |
|
I tried to reopen, but it looks like you might need to file a new PR... it won't let me. :-/ Sorry, mate. |
|
Ah, OK, no worries. Opened #163 . |
BTW @cgiffard, I could set up JSCS and or ESLint to make things more consistent across the codebase.
Also, I was thinking, maybe we should just move JSHint in package.json script section?