extension stops the URL from being updated

[moloko]

if you're on a page and you get the prompt, clicking 'Yes' will navigate to the new location but leave the location.hash unchanged i.e. if you're on co-05, click the menu button, click 'yes' on the prompt then you'll be returned to the menu but the URL will remain "index.html#/id/co-05" - but it should change to "index.html#/"

[moloko]

OK through a bit of trial and error I have figured out that if I remove the final line of code - this.handleRoute.apply(this, args); - from the function navigateToArguments in router.js then it appears to fix this... but I'm a bit wary of doing this without really understanding the impact of this change... @oliverfoster could you offer any advice here?

[oliverfoster]

I'd say this behaviour all need rewriting and thinking out properly. It's just a horrible mess of circular hacks.

[moloko]

@oliverfoster pageIncompletePrompt or router.js?

[oliverfoster]

Probably both. Mostly router.js

The idea of preHooking, stopping and then later resuming the routing is reasonable. Obviously either the arguments or the url hash need to be captured and there needs to be some sensible method of passing a route back into the router (window.location.href seems like a good candidate rather than passing arguments around).

Reverting or stopping a hash change in the browser history is a bit of a problem with the backbone router. Which is where all this daft code came from.

[moloko]

fixed in v2.0.5