Add checkcasts for arguments of invoked bridges

[cushon]

This fixes a TODO in Enhancer: the assumption that a bridge's parameters
are assignable to the target's parameters doesn't hold in certain
cross-compilation scenarios.

The included test case fails with a VerifyError if the checkcasts are
omitted.

Also, make BridgeMethodResolver use the same class loader as Enhancer to
make it easier to test.

[sameb]

Thanks Liam! Do you know if this fixes the same issue described in #89?

On Mon, Sep 19, 2016, 6:34 PM Liam Miller-Cushon notifications@github.com
wrote:

This fixes a TODO in Enhancer: the assumption that a bridge's parameters
are assignable to the target's parameters doesn't hold in certain
cross-compilation scenarios.

The included test case fails with a VerifyError if the checkcasts are
omitted.

Also, make BridgeMethodResolver use the same class loader as Enhancer to

make it easier to test.

You can view, comment on, or merge this pull request online at:

#90
Commit Summary

• Add checkcasts for arguments of invoked bridges

File Changes

• M cglib/src/main/java/net/sf/cglib/proxy/BridgeMethodResolver.java
  https://github.com/cglib/cglib/pull/90/files#diff-0 (14)
• M cglib/src/main/java/net/sf/cglib/proxy/CallbackGenerator.java
  https://github.com/cglib/cglib/pull/90/files#diff-1 (2)
• M cglib/src/main/java/net/sf/cglib/proxy/Enhancer.java
  https://github.com/cglib/cglib/pull/90/files#diff-2 (20)
• M
  cglib/src/main/java/net/sf/cglib/proxy/MethodInterceptorGenerator.java
  https://github.com/cglib/cglib/pull/90/files#diff-3 (3)
• M cglib/src/main/java/net/sf/cglib/proxy/NoOpGenerator.java
  https://github.com/cglib/cglib/pull/90/files#diff-4 (3)
• M cglib/src/test/java/net/sf/cglib/proxy/TestEnhancer.java
  https://github.com/cglib/cglib/pull/90/files#diff-5 (167)

Patch Links:

• https://github.com/cglib/cglib/pull/90.patch
• https://github.com/cglib/cglib/pull/90.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#90, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACC7EhfrGH_1YRzLU-VCJkusnJm4grI9ks5qrw3dgaJpZM4KBCcc
.