PR: Fix PyHELP crashing when a cell has 0 valid layer but is flagged to be run in HELP. #60

jnsebgosselin · 2019-03-01T14:56:28Z

In the method HelpManager.get_run_cellnames, we simply filter the cells that have a nlayer=0, so that PyHELP doesn't crash when executing HelpManager.build_help_input_files

Otherwise, it makes PyHELP crash when nlayer is 0, but run is 1.

Keep only cells with nlayer > 0 in run_cellnames

8334c29

Otherwise, it makes PyHELP crash when nlayer is 0, but run is 1.

jnsebgosselin added the type: bug Something isn't working label Mar 1, 2019

jnsebgosselin added this to the 0.1.2 milestone Mar 1, 2019

jnsebgosselin self-assigned this Mar 1, 2019

jnsebgosselin changed the base branch from master to 0.1.x March 1, 2019 15:22

jnsebgosselin merged commit 2277f69 into 0.1.x Mar 1, 2019

jnsebgosselin added a commit that referenced this pull request Mar 1, 2019

Merge from branch '0.1.x': PR #60

af71919

jnsebgosselin deleted the exclude_nlayer0_from_runcell branch March 1, 2019 15:53

jnsebgosselin mentioned this pull request Mar 1, 2019

PR: Pin numpy to 1.15.* series or else building the HELP3O extension fails. #61

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR: Fix PyHELP crashing when a cell has 0 valid layer but is flagged to be run in HELP. #60

PR: Fix PyHELP crashing when a cell has 0 valid layer but is flagged to be run in HELP. #60

jnsebgosselin commented Mar 1, 2019 •

edited

PR: Fix PyHELP crashing when a cell has 0 valid layer but is flagged to be run in HELP. #60

PR: Fix PyHELP crashing when a cell has 0 valid layer but is flagged to be run in HELP. #60

Conversation

jnsebgosselin commented Mar 1, 2019 • edited

jnsebgosselin commented Mar 1, 2019 •

edited