PR: Remove utilities to format pyHELP input weather data from InfoClimat grid and CWEEDS files #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not want to support this feature anymore. It is up to the users to pre-process their weather data.
It is up to the user to format their input files. We don't want to support this anymore, it is too much maintenance work.
We do not need this anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting these features is too much maintenance work.
The InfoClimat (https://www.environnement.gouv.qc.ca/climat/surveillance/produits.htm) weather grid is not available publicly, so this makes the usefulness of this feature quite limited.
CWEEDS files are not updated for recent years (>2017). There are better source of radiation data out there that can be use instead, such as https://cds.climate.copernicus.eu/cdsapp#!/dataset/sis-agrometeorological-indicators?tab=form.