Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Get rid of the year_range argument in the HelpManager constructor #75

Merged
merged 8 commits into from Mar 16, 2022

Conversation

jnsebgosselin
Copy link
Member

@jnsebgosselin jnsebgosselin commented Mar 16, 2022

The year_range argument was confusing and not very useful.

  • Removed the year_range argument in the HelpManager constructor. The year range is now determined from the precipitation dataset.
  • Added a lot of checks to make sure weather data are complete and synchronous.
  • Added a lot of CI tests for the reading of input weather datasets.

@jnsebgosselin jnsebgosselin added this to the 0.2.1 milestone Mar 16, 2022
@jnsebgosselin jnsebgosselin self-assigned this Mar 16, 2022
@jnsebgosselin jnsebgosselin merged commit c5d5e65 into master Mar 16, 2022
@jnsebgosselin jnsebgosselin deleted the get_rid_of_year_range branch March 17, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant