Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GemGIS 1.1.1 #299

Merged
merged 18 commits into from
Sep 23, 2023
Merged

GemGIS 1.1.1 #299

merged 18 commits into from
Sep 23, 2023

Conversation

AlexanderJuestel
Copy link
Collaborator

@AlexanderJuestel AlexanderJuestel commented Aug 21, 2023

Description

Bug Fixes, improvements, and new functionality

Relates to #298, #300, #301, #302

Checklist

  • My code follows the PEP 8 style guidelines.
  • My code uses type hinting for function and method arguments and return values.
  • My code contains descriptive and helpful docstrings
    which are formatted per the Google Python Style Guidelines.
  • I have created tests which entirely cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New and existing tests pass locally with my changes.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

project.toml Outdated
@@ -0,0 +1,40 @@
[build-system]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @AlexanderJuestel this file should be called pyproject.toml rather than project.toml :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew it looked different to other files

project.toml Outdated
"geographic-data", "spatial-data", "notebooks", "raster-data", "vector-data", "geographic", "geomodeling"]
readme = "README.md"
license = {file = LICENSE}
dynamic = ["Version"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you go with dynamic versioning (which is great) you'll want to add the items that i suggested in discourse to your initi file so you can call your package.__version__ properly

project.toml Outdated
Comment on lines 8 to 10
authors = [
{name = "Alexander Jüstel", email = "alexander.juestel@rwth-aachen.de"},
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is an authors key and a maintainers key. but it would be good to migrate all of your authors over

Arthur Endlein Correia, Florian Wellmann, Marius Pischke ...
it is ok if you don't have everyone's emails you can either skip the email key totally or just skip those without emails. i've found it easiest to just skip emails if you don't have everyone. Or you could make a maintainer list with just names too the format is the same as authors.

maintainers = [
    {name = "Alexander Jüstel"},
    {name= "Arthur Endlein Correia"},
     {another name here...}
]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

project.toml Outdated
{name = "Alexander Jüstel", email = "alexander.juestel@rwth-aachen.de"},
]
description = "Spatial data processing for geomodeling"
keywords = ["visualization", "python", "processing", "jupyter", "modeling", "geospatial", "jupyter-notebook",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice list of keywords but you might think about these in terms of words that directly relate to your package's functionality to help users find it. i'm not sure if jupyter is one you wish to use unless you somehow are building a tool that integrates into jupyter? maybe you are - just be sure these are specific to your package as it helps people find you on pypi

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapted

project.toml Outdated
"rasterio",
"pyvista",
]
[project.urls]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left a comment here that i think you can ignore about the quotes.

@AlexanderJuestel AlexanderJuestel merged commit 5ecbc45 into main Sep 23, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants