mock tests fails on cygwin64 - because of typing problems

[thoni56]

On Cygwin64 a couple of tests fails (always_expect_keeps_affirming_parameter, expect_a_sequence and learning_mocks_emit_pastable_code), all because of the va_arg unpacking wrong size of data.

It seems that on Cygwin64 uintptr_t are bigger than int so when an int argument to mock() is unpacked often garbage is included.

(Strange thing is that those tests have code that causes multiple evaluation of constraints and every one fails on this problem except the last one in the test, no matter how many you add....)

They pass if the argument to the mocked function is defined as uintptr_t so this is some kind of proof of the problem.

Is there a way to force a type cast to uintptr_t to all VA_ARGS in the mock() macro?

I suppose I'm asking @matthargett primarily, but any input is appreciated.

[thoni56]

Adding a cast in the macro like

..., (uintptr_t)__VA_ARGS__, ...

works, but I am assuming this only covers the first argument.

[thoni56]

SO has one answer: http://stackoverflow.com/questions/11920577/casting-all-parameters-passed-in-macro-using-va-args...

[thoni56]

Ok, so problem was not applying the cast to actual arguments to mock(). That is done already. But only if there are more than one...

[thoni56]

Ok, created a PR with a fix, so closing this.