never_expect counts as a pass when a mock is never called #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to count `never_expect` assertions as a passing test when the mocked function is never called. Due to current implementation a new field in `RecordedExpectation` struct was added to ensure that a expectation that will be always present knows if it as been triggered. Add some tests for scenarios where `never_expect` is called when a `expect` or `always_expect` is already present.
joaopapereira
force-pushed
the
never_expect-count-as-assertion
branch
from
413c87e
to
3d70014
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to count
never_expectassertions as a passing test when the mocked function is never called.Due to current implementation a new field in
RecordedExpectationstruct was added to ensure that a expectation that will be always present knows if it as been triggered.Add some tests for scenarios where
never_expectis called when aexpectoralways_expectis already present.Fixes #165