Changed the description of 'have_attribute_matcher' from 'has' to 'have' #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. You'll need to update the matcher's specs before I can merge this in. |
|
Just added a commit with the updated matcher specs. Should be good to go. |
cgriego
added a commit
that referenced
this pull request
Jun 16, 2013
Changed the description of 'have_attribute_matcher' from 'has' to 'have'
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the description of 'have_attribute_matcher' from 'has' to 'have' to be more consistent with descriptions used by other Rspec matchers. It also now reads as proper english when you view the spec output with flag '--format documentation'.
BEFORE:
it { should have_attribute(:email) }
=> should has attribute named email
AFTER:
it { should have_attribute(:email) }
=> should have attribute named email