Fixed validation failing when using allow_nil => true options

[sankaranarayanan]

No description provided.

[cgriego]

@sankaranarayanan Can you share some example model code, how it behaves, and how you expect it to behave?

[sankaranarayanan]

If you set to a empty string, it should return nil not 0. it should not type cast to to_i. That's why its failing in validations

check the example
In ActiveAttr::Model
user = User.new(:age => '')
=> User age: 0
user = User.new(:age => '')
=> User age: 0
user.age
=> 0

In ActiveRecord
user = User.new(:age => '')
=> UserInfo id: nil, age: nil, created_at: nil, updated_at: nil
user
=> User id: nil, age: nil, created_at: nil, updated_at: nil
user.age
=> nil

[cgriego]

Which validations? Please share some example model code.

[sankaranarayanan]

class User
include ActiveAttr::Model
attribute :age, type: Integer

validates :age, :numericality => {:greater_than_or_equal_to => 0, :less_than_or_equal_to => 100}, :allow_nil => true
end

user = User.new(:age => '')
user.valid?
=> false
user.errors
=> ActiveModel::Errors:0xa8f3c5c @base=#<User age: 0>, @messages={:age=>["is not a number"]}

[cgriego]

Thank you for the details, @sankaranarayanan.

[AvnerCohen]

@cgriego is there any plan to merge this?

[joankaradimov]

+1

[razitz]

+1

[brynjargr]

@cgriego Will this ever get merged? As it stands, this issue is preventing me from being able to use this gem.

[andrewgilbert12]

+1

[vladislav-zubov]

+1