Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with angular 1.3.0.rc.3 #44

Closed
LeleDev opened this issue Sep 24, 2014 · 15 comments
Closed

Not working with angular 1.3.0.rc.3 #44

LeleDev opened this issue Sep 24, 2014 · 15 comments

Comments

@LeleDev
Copy link

LeleDev commented Sep 24, 2014

With angular 1.3.0.rc.3 I get the following error:

TypeError: Cannot read property '$$state' of undefined
    at Uc.d.then (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.3/angular.min.js:107:139)
    at d (file:///mnt/Partizione1/Lele/Lavoro/Github%20projects/k2hire/bower_components/angular-busy/dist/angular-busy.min.js:1:940)
    at file:///mnt/Partizione1/Lele/Lavoro/Github%20projects/k2hire/bower_components/angular-busy/dist/angular-busy.min.js:1:349
    at Object.r [as forEach] (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.3/angular.min.js:7:298)
    at Object.c.reset (file:///mnt/Partizione1/Lele/Lavoro/Github%20projects/k2hire/bower_components/angular-busy/dist/angular-busy.min.js:1:294)
    at file:///mnt/Partizione1/Lele/Lavoro/Github%20projects/k2hire/bower_components/angular-busy/dist/angular-busy.min.js:1:2252
    at Object.fn (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.3/angular.min.js:117:127)
    at k.$digest (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.3/angular.min.js:118:250)
    at k.$apply (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.3/angular.min.js:121:264)
    at http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.3/angular.min.js:18:101 angular.js:10683(anonymous function) angular.js:10683(anonymous function) angular.js:7858k.$digest angular.js:13292k.$apply angular.js:13540(anonymous function) angular.js:1483e angular.js:4112d angular.js:1481ic angular.js:1501xd angular.js:1395(anonymous function) angular.js:24696j jquery.min.js:2k.fireWith jquery.min.js:2n.extend.ready jquery.min.js:2I jquery.min.js:

It works fine instead with angular 1.2.25

@devniel
Copy link

devniel commented Sep 25, 2014

I've got some errors with 1.3.0.rc.3 too

@smithkl42
Copy link

Ditto (except with rc2).

TypeError: Cannot read property '$$state' of undefined
    at Promise.then (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.2/angular.js:12184:11)
    at addPromiseLikeThing (http://dev.payboard.com/bower_components/angular-busy/angular-busy.js:67:4)
    at http://dev.payboard.com/bower_components/angular-busy/angular-busy.js:22:5
    at Object.forEach (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.2/angular.js:331:20)
    at Object.tracker.reset (http://dev.payboard.com/bower_components/angular-busy/angular-busy.js:18:12)
    at http://dev.payboard.com/bower_components/angular-busy/angular-busy.js:175:15
    at Object.$watchCollectionAction [as fn] (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.2/angular.js:13125:13)
    at Scope.$get.Scope.$digest (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.2/angular.js:13262:29)
    at Scope.$get.Scope.$apply (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.2/angular.js:13528:24)
    at done (http://ajax.googleapis.com/ajax/libs/angularjs/1.3.0-rc.2/angular.js:8893:47) 

@dryamvlad
Copy link

Same problem with 1.3.0.rc.4

@LeleDev
Copy link
Author

LeleDev commented Oct 2, 2014

This one seems to help: #37

@kaifer
Copy link

kaifer commented Oct 10, 2014

I've got some errors with 1.3.0.rc.4 too.

No more error occurred since I have fixed some lines of the source code.
but, I do not consider another version.
line 67 (in angular-busy.js)

Before

        then(function(){
            promise.$cgBusyFulfilled = true;
            if (tracker.promises.indexOf(promise) === -1) {
                return;
            }
            tracker.promises.splice(tracker.promises.indexOf(promise),1);
        },function(){
            promise.$cgBusyFulfilled = true;
            if (tracker.promises.indexOf(promise) === -1) {
                return;
            }
            tracker.promises.splice(tracker.promises.indexOf(promise),1);
        });

After

        var onFulfilled = function(){
            promise.$cgBusyFulfilled = true;
            if (tracker.promises.indexOf(promise) === -1) {
                return;
            }
            tracker.promises.splice(tracker.promises.indexOf(promise),1);
        };
        var onRejected = function(){
            promise.$cgBusyFulfilled = true;
            if (tracker.promises.indexOf(promise) === -1) {
                return;
            }
            tracker.promises.splice(tracker.promises.indexOf(promise),1);
        };
        then.call(promise,onFulfilled,onRejected);

@dlouwers
Copy link

Can we get a release for bower? I can patch it locally but don't know how to distribute this to the team.

@venkatramachandran
Copy link

After making this change, I get the following error (with angular 1.3.0-rc.4 ):

TypeError: Cannot read property 'pending' of undefined
    at Resource.Promise.then (http://192.168.56.102:90/bower_components/angular/angular.js:12252:42)
    at addPromiseLikeThing (http://192.168.56.102:90/bower_components/angular-busy/angular-busy.js:81:12)
    at http://192.168.56.102:90/bower_components/angular-busy/angular-busy.js:22:9
    at Object.forEach (http://192.168.56.102:90/bower_components/angular/angular.js:330:20)
    at Object.tracker.reset (http://192.168.56.102:90/bower_components/angular-busy/angular-busy.js:18:15)
    at http://192.168.56.102:90/bower_components/angular-busy/angular-busy.js:177:21
    at Object.$watchCollectionAction [as fn] (http://192.168.56.102:90/bower_components/angular/angular.js:13206:13)
    at Scope.$digest (http://192.168.56.102:90/bower_components/angular/angular.js:13341:29)
    at Scope.$apply (http://192.168.56.102:90/bower_components/angular/angular.js:13603:24)
    at done (http://192.168.56.102:90/bower_components/angular/angular.js:8935:47) 

Any ideas to fix this?

@cheneywan
Copy link

Same problem with 1.3.0

TypeError: Cannot read property '$$state' of undefined
at Promise.then (http://localhost:8080/py6/js/vendor.js:12876:11)
at addPromiseLikeThing (http://localhost:8080/py6/js/vendor.js:29226:4)
at http://localhost:8080/py6/js/vendor.js:29181:5
at Object.forEach (http://localhost:8080/py6/js/vendor.js:335:20)
at Object.tracker.reset (http://localhost:8080/py6/js/vendor.js:29177:12)
at http://localhost:8080/py6/js/vendor.js:29334:15
at Object.$watchCollectionAction as fn
at Scope.$digest (http://localhost:8080/py6/js/vendor.js:13965:29)
at Scope.$apply (http://localhost:8080/py6/js/vendor.js:14227:24)
at HTMLButtonElement. (http://localhost:8080/py6/js/vendor.js:33091:13)

@ALMMa
Copy link

ALMMa commented Oct 17, 2014

@kaifer's approach worked here too, with default settings.

@hyzhak
Copy link

hyzhak commented Oct 17, 2014

+1

@hyzhak
Copy link

hyzhak commented Oct 18, 2014

@cgross pls pull my request and publish new update to the bower we need it to use new version of angular 1.3

@hyzhak
Copy link

hyzhak commented Oct 18, 2014

@cgross sorry, I just can't wait for new version of angular-busy, so I've created temporary bower module with this pull request. It can be installed that way:

$ bower info angular-busy-too --save

@cgross
Copy link
Owner

cgross commented Oct 19, 2014

Fixed and published to bower. Thanks guys.

@marcelorl
Copy link

Hi,

I had the same issue again with angular 1.4.8, then I implemented @kaifer solution and it worked smoothly. Could you please pull his solution to the project?

Thanks.

@orcunland
Copy link

orcunland commented Jul 6, 2017

Hi,

I am now experiencing the same problem with AngularJS 1.6.4 after upgrading my Angular version from 1.2.16.
I am using bower 1.8.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests