Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retransmission not working #5

Closed
cguimaraes opened this issue Aug 3, 2023 · 0 comments · Fixed by #6
Closed

Retransmission not working #5

cguimaraes opened this issue Aug 3, 2023 · 0 comments · Fixed by #6
Assignees
@cguimaraes

Comments

@cguimaraes
Copy link
Owner

Messages are not being retransmitted upon timeout.

public void run() {
    Logger.getGlobal().info("RUN");
    if (i > retries) {
        ++i;
        try {
            socket.send(socketPacket);
        } catch (IOException e) {
            e.printStackTrace();
        }
    }
}

if (i > retries) shall be if (i < retries) instead.
@cguimaraes cguimaraes self-assigned this Aug 3, 2023
@cguimaraes cguimaraes mentioned this issue Aug 3, 2023
Merged
cguimaraes added a commit that referenced this issue Aug 3, 2023
@cguimaraes
Fix retransmission condition against number of retries (#5) (#6)
53084cc
cguimaraes added a commit that referenced this issue Aug 3, 2023
@cguimaraes
Fix retransmission condition against number of retries (#5) (#6)
d47db82
cguimaraes added a commit that referenced this issue Aug 4, 2023
@cguimaraes
Support for TFTP Timeout Interval Option according to RFC 2349 (#7)
826bd17 
* Rename options to arguments

* Add support for timeout interval option

* Remove runnable implementation for tftp socket

* Add tests for timeout interval option

* Fix roundup interval

* Validate timeout interval range

* Update usage with range for timeout interval

* Update log message for invalid timeout interval received from peer

* Update Readme to mention support to timeout interval

* Use send from socket with retransmissions

* Fix retransmission condition against number of retries (#5) (#6)

* Disable retransmissions only for error messages

* Add extra validations for timeout interval in OACK

* Update tests to comprise change in the argument option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cguimaraes cguimaraes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix retransmission condition against number of retries (#5) cguimaraes/ssTFTP
1 participant
@cguimaraes