Skip to content

Commit

Permalink
35coreos-multipath: propagate after Ignition files stage
Browse files Browse the repository at this point in the history
We didn't have a strong ordering between the propagation service and the
Ignition `files` stage. We need to run after it so that we only
propagate the multipath config if the Ignition config didn't create one.

In practice currently the propagation service runs before, which didn't
cause any issues because Ignition can still just clobber what we
propagated. But it could become racier in the future, and it's confusing
because the logic we run and messages we log assume the `files` stage
ran.
  • Loading branch information
jlebon committed Jul 12, 2022
1 parent f5ec625 commit 55c8d7c
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ Before=initrd.target
# we write to the rootfs, so run after it's ready
After=initrd-root-fs.target

# we only propagate if multipath wasn't configured via Ignition
After=ignition-files.service

# That service starts initrd-cleanup.service which will race with us completing
# before we get nuked. Need to get to the bottom of it, but for now we need
# this (XXX: add link to systemd issue here).
Expand Down

0 comments on commit 55c8d7c

Please sign in to comment.