Merge pull request #1478 from NicoPennec/fix/eslint

Various fixes
cgwire · Jul 8, 2024 · dafa924 · dafa924
2 parents eade789 + 4194146
commit dafa924
Show file tree

Hide file tree

Showing 80 changed files with 386 additions and 367 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -6,7 +6,7 @@ module.exports = {
   },
   extends: [
     'eslint:recommended',
-    'plugin:vue/essential',
+    'plugin:vue/recommended',
     'plugin:prettier/recommended'
   ],
   rules: {
@@ -21,10 +21,21 @@ module.exports = {
         destructuring: 'all'
       }
     ],
+
+    // additional rules for Vue
+    'vue/component-definition-name-casing': ['error', 'kebab-case'],
     'vue/component-name-in-template-casing': ['error', 'kebab-case'],
+    'vue/prop-name-casing': ['error', 'camelCase'],
+
+    // disabled vue/recommended rules
+    'vue/attributes-order': 'off',
     'vue/multi-word-component-names': 'off',
+    'vue/no-lone-template': 'off',
     'vue/no-use-v-if-with-v-for': 'off',
-    'vue/prop-name-casing': ['error', 'camelCase']
-  },
-  globals: {}
+    'vue/no-v-html': 'off',
+    'vue/order-in-components': 'off',
+    'vue/require-default-prop': 'off',
+    'vue/require-prop-types': 'off',
+    'vue/no-template-shadow': 'off'
+  }
 }
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -11,7 +11,7 @@
     "dev": "vite",
     "build": "vite build",
     "preview": "vite preview",
-    "lint": "eslint --ext .js,.vue --ignore-path .gitignore src/",
+    "lint": "eslint --ext .js,.vue src/",
     "lint:fix": "npm run lint -- --fix",
     "format": "prettier --write --list-different src/**/*.{js,vue}",
     "test:unit": "vitest tests/unit",
@@ -24,7 +24,7 @@
     "@fullcalendar/multimonth": "6.1.14",
     "@fullcalendar/vue": "6.1.14",
     "@google/model-viewer": "3.5.0",
-    "@sentry/vue": "8.14.0",
+    "@sentry/vue": "8.15.0",
     "async": "3.2.5",
     "bowser": "2.11.0",
     "chart.js": "2.9.4",
@@ -90,6 +90,6 @@
     "node": ">=18.12"
   },
   "lint-staged": {
-    "*.{js,vue}": "eslint --cache --fix"
+    "*.{js,vue}": "eslint --cache"
   }
 }
diff --git a/src/components/cells/TaskStatusCell.vue b/src/components/cells/TaskStatusCell.vue
@@ -2,7 +2,7 @@
   <td class="name">
     <div
       class="tag"
-      v-bind:class="[!disable ? '' : 'canceled']"
+      :class="{ canceled: disable }"
       :style="{
         background: color,
         color: textColor

diff --git a/src/components/lists/AssetList.vue b/src/components/lists/AssetList.vue
@@ -189,7 +189,7 @@
 
               <table-metadata-selector-menu
                 ref="headerMetadataSelectorMenu"
-                :metadataDisplayHeaders.sync="metadataDisplayHeaders"
+                :metadata-display-headers.sync="metadataDisplayHeaders"
                 :descriptors="assetMetadataDescriptors"
                 :exclude="{
                   timeSpent: !isAssetTime,
@@ -307,8 +307,8 @@
               :entity="asset"
               :task-test="taskMap.get(asset.validations.get(columnId))"
               :selected="isSelected(i, k, j)"
-              :rowX="getIndex(i, k)"
-              :columnY="j"
+              :row-x="getIndex(i, k)"
+              :column-y="j"
               :minimized="hiddenColumns[columnId]"
               :is-static="true"
               :is-assignees="isShowAssignations"
@@ -406,8 +406,8 @@
               :selected="
                 isSelected(i, k, j + stickedDisplayedValidationColumns.length)
               "
-              :rowX="getIndex(i, k)"
-              :columnY="j"
+              :row-x="getIndex(i, k)"
+              :column-y="j"
               :minimized="hiddenColumns[columnId]"
               :is-static="true"
               :is-assignees="isShowAssignations"

diff --git a/src/components/lists/EditList.vue b/src/components/lists/EditList.vue
@@ -172,7 +172,7 @@
 
               <table-metadata-selector-menu
                 ref="headerMetadataSelectorMenu"
-                :metadataDisplayHeaders.sync="metadataDisplayHeaders"
+                :metadata-display-headers.sync="metadataDisplayHeaders"
                 :descriptors="editMetadataDescriptors"
                 :exclude="{
                   timeSpent: !isEditTime,
@@ -308,7 +308,7 @@
                 'datatable-row-header': true
               }"
               :column="taskTypeMap.get(columnId)"
-              :columnY="j"
+              :column-y="j"
               :entity="edit"
               :is-assignees="isShowAssignations"
               :is-static="true"
@@ -318,7 +318,7 @@
                   : '0'
               "
               :minimized="hiddenColumns[columnId]"
-              :rowX="i"
+              :row-x="i"
               :selected="isSelected(i, j)"
               :sticked="true"
               :task-test="taskMap.get(edit.validations.get(columnId))"
@@ -396,8 +396,8 @@
               :selected="
                 isSelected(i, j + stickedDisplayedValidationColumns.length)
               "
-              :rowX="i"
-              :columnY="j"
+              :row-x="i"
+              :column-y="j"
               :is-assignees="isShowAssignations"
               @select="onTaskSelected"
               @unselect="onTaskUnselected"

diff --git a/src/components/lists/EpisodeList.vue b/src/components/lists/EpisodeList.vue
@@ -176,7 +176,7 @@
 
               <table-metadata-selector-menu
                 ref="headerMetadataSelectorMenu"
-                :metadataDisplayHeaders.sync="metadataDisplayHeaders"
+                :metadata-display-headers.sync="metadataDisplayHeaders"
                 :descriptors="episodeMetadataDescriptors"
                 :exclude="{
                   timeSpent: !isEpisodeTime,
@@ -262,7 +262,7 @@
                 'datatable-row-header': true
               }"
               :column="taskTypeMap.get(columnId)"
-              :columnY="j"
+              :column-y="j"
               :entity="episode"
               :is-assignees="isShowAssignations"
               :is-static="true"
@@ -272,7 +272,7 @@
                   : '0'
               "
               :minimized="hiddenColumns[columnId]"
-              :rowX="i"
+              :row-x="i"
               :selected="isSelected(i, j)"
               :sticked="true"
               :task-test="taskMap.get(episode.validations.get(columnId))"
@@ -377,8 +377,8 @@
               :selected="
                 isSelected(i, j + stickedDisplayedValidationColumns.length)
               "
-              :rowX="i"
-              :columnY="j"
+              :row-x="i"
+              :column-y="j"
               :is-assignees="isShowAssignations"
               @select="onTaskSelected"
               @unselect="onTaskUnselected"