Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve avatar loading #1204

Merged
merged 8 commits into from
Sep 29, 2023
Merged

Improve avatar loading #1204

merged 8 commits into from
Sep 29, 2023

Conversation

NicoPennec
Copy link
Member

Problem
User avatar images are loaded too many times because they are not effectively cached.
This unnecessarily increases the network load.

Solution

  • Refactor how to cache images and sync people in the UI, based on each person's last update date.
  • Replace v-lazy library by native lazy loading.
  • Add an option to disable lazy loading when necessary.

@PeteDraper
Copy link

The images are also too big for the icon sizes - you can save out the image by right-clicking the icon to find out how big it is... for an icon it's exceptionally large. Needs downsizing for different uses akin to how the shot thumbnails work. This will also speed up page load effectively.

@NicoPennec
Copy link
Member Author

Hi @PeteDraper, you are completely right! This is a point that we have also identified and will look to improve the image ratio following the different display cases. It will be the subject of another pull request 😉

@NicoPennec NicoPennec merged commit 14bf42a into cgwire:master Sep 29, 2023
4 checks passed
@NicoPennec NicoPennec deleted the fix/avatar branch September 29, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants