Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Wouter Knoben's contribution to the ERA5 downloads #6

Closed
kasra-keshavarz opened this issue Aug 31, 2022 · 2 comments
Closed
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@kasra-keshavarz
Copy link
Collaborator

kasra-keshavarz commented Aug 31, 2022

Issue description

The download scripts available at here need to acknowledge Wouter Knoben's contributions including parts of the CWARHM workflow.

@kasra-keshavarz kasra-keshavarz added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 31, 2022
@kasra-keshavarz kasra-keshavarz added this to the v0.2.0 milestone Aug 31, 2022
@ShervanGharari
Copy link

It is cleaner to point at the CWARHM repo instead of having the zip file.
Also mentioned Guoqiang as the data on Graham was downloaded by him to my knowledge.
In general sense, the datatool, should be separate from the download script and credit. Users may want to use it in different place with different download tools, or the version of ERA5 they have. Something to consider on where the best place of credit should be.

@kasra-keshavarz kasra-keshavarz mentioned this issue Sep 19, 2022
@kasra-keshavarz
Copy link
Collaborator Author

Solved with #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants