Add constructor resolution to datacontractresolver #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstelljes
approved these changes
Nov 22, 2019
dstelljes
requested changes
Nov 26, 2019
There was a problem hiding this comment.
a few small things, otherwise 👍
also if you want practice updating the documentation site, at some point the mapping guide will need to be updated to reflect these changes
| @@ -347,6 +347,13 @@ public override TypeResolution Resolve(Type type) | |||
| /// </summary> | |||
| public class EnumResolverCase : ReflectionResolverCase | |||
| { | |||
| /// <summary> | |||
There was a problem hiding this comment.
not needed on EnumResolverCase?
| @@ -445,6 +452,22 @@ public override TypeResolution Resolve(Type type) | |||
| /// </summary> | |||
| public class EnumerableResolverCase : ReflectionResolverCase | |||
| { | |||
| /// <summary> | |||
| /// The binding flags that will be used to select fields and properties. | |||
There was a problem hiding this comment.
constructors in this case, not fields and properties
| /// Creates a new object resolver case. | ||
| /// </summary> | ||
| /// <param name="memberVisibility"> | ||
| /// The binding flags that will be used to select fields and properties. |
There was a problem hiding this comment.
constructors in this case, not fields and properties
dstelljes
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.