Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label propagation #122

Merged
merged 1 commit into from Dec 11, 2022
Merged

Add label propagation #122

merged 1 commit into from Dec 11, 2022

Conversation

ch-sa
Copy link
Owner

@ch-sa ch-sa commented Dec 4, 2022

  • add a feature to carry over labels to the next point cloud
  • can be activated via config and menu action
  • will only copy labels if the next point cloud has no bounding boxes so far

Closes: #120

@ch-sa ch-sa added the feature New feature or request label Dec 4, 2022
@ch-sa ch-sa requested a review from chingyulin December 4, 2022 14:36
@ch-sa ch-sa self-assigned this Dec 4, 2022
@ch-sa
Copy link
Owner Author

ch-sa commented Dec 4, 2022

TODO

  • test
  • update documentation
  • add to settings dialog

@chingyulin
Copy link
Collaborator

Nice feature to have and implementation-wise looks good to me. 👍

@ch-sa
Copy link
Owner Author

ch-sa commented Dec 4, 2022

Cool, I will also then finally merge the semantic segmentation feature.

However, we should not forget that labelCloud crashes for semantic segmentation when the point cloud already has labels with ids that are not part of the _classes.json.

@chingyulin Can I create an issue for you to handle this?

@chingyulin
Copy link
Collaborator

Hi @ch-sa again,

Yes, sorry haven't found a time to do it yet. Please create a ticket and assign me.

 - add a feature to carry over labels to the next point cloud
 - can be activated via config and menu action
 - will only copy labels if the next point cloud has no bounding boxes so far
 - add checkbox to settings dialog
 - add to documentation

Closes: #120
@ch-sa ch-sa merged commit 0832048 into master Dec 11, 2022
@ch-sa ch-sa deleted the ch-sa/bbox-propagation branch December 11, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Propagating boxes between point clouds
2 participants