Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

网站logo建议缓存在服务端 #32

Closed
JackMaBaLaBaLa opened this issue May 17, 2023 · 3 comments
Closed

网站logo建议缓存在服务端 #32

JackMaBaLaBaLa opened this issue May 17, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@JackMaBaLaBaLa
Copy link

对于自动获取的logo,每次打开导航站会访问logo所在网站获取。如果网络环境差的情况,会花不少时间去获取logo,并且可能出现获取不到logo的情况,影响到导航站的展示,拖累性能。
建议获取一次logo后,可以保存在服务端,从服务端拉取logo。

@ch3nnn
Copy link
Owner

ch3nnn commented May 17, 2023

感谢建议, 当时也在考虑要不要做本地图片管理。想过有两种实现方式, 1. 如果是简单实现就是在静态资源创建文件夹做管理 2. 要么上 minio 做私有对象存储。后面我考虑一下这块要不要拓展把这个地方优化下。

@ch3nnn ch3nnn added the enhancement New feature or request label May 17, 2023
@ch3nnn
Copy link
Owner

ch3nnn commented May 19, 2023

已新增。先从静态资源实现 #34

@JackMaBaLaBaLa
Copy link
Author

已新增。先从静态资源实现 #34
发现了一个小问题。就是对于自动获取成功的网站logo是缓存在服务端了。对于有些自动获取logo失败,手动填写logo图片地址的情况,并没有缓存在服务端。

@ch3nnn ch3nnn closed this as completed Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants