Properly handle replace situations in storages

chEbba · Oct 27, 2012 · 9d7e52d · 9d7e52d
1 parent 4b52c30
commit 9d7e52d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/Composer/Storage/ArchiveStorage.php b/src/Composer/Storage/ArchiveStorage.php
@@ -75,12 +75,12 @@ public function storePackage(PackageInterface $package, $sourceDir)
             throw new \RuntimeException('Can not initialize directory structure in ' . $dir);
         }
 
-        if (file_exists($fileName)) {
-            @unlink($fileName);
+        $tempFileName = sys_get_temp_dir().'/'.uniqid(basename($fileName));
+        $this->compressor->compressDir($sourceDir, $tempFileName);
+        if (!@rename($tempFileName, $fileName)) {
+            throw new \RuntimeException(sprintf('Can not rename file from %s to %s.', $tempFileName, $fileName));
         }
 
-        $this->compressor->compressDir($sourceDir, $fileName);
-
         return $this->createDistribution($fileName);
     }
 

diff --git a/src/Composer/Storage/RepositoryStorage.php b/src/Composer/Storage/RepositoryStorage.php
@@ -71,6 +71,10 @@ public function storePackage(PackageInterface $package, $sourceDir)
 
         $packageCopy = self::convertPackage($package, $dist);
 
+        // Remove old package from repository in a replace situation
+        if ($this->repository->hasPackage($package)) {
+            $this->repository->removePackage($package);
+        }
         $this->repository->addPackage($packageCopy);
         $this->repository->write();