Make Android 23 compatible #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened ticket #2 regarding this effort |
|
@codlab As long as this builds, I have no problem with lowering the minimum Android version. However, usually I like to keep the bumping of the version in a separate commit. This makes it easier for tagging and history purposes. Could you remove the bumping of the library version from this PR? I will increment the version when tag and release. |
codlab
force-pushed
the
feature/accept_android_23
branch
from
6634bb8
to
b007d3a
Compare
|
Sure, no problem 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this library in a project currently but the minimum version of Android is set to 25. However looking at the implementation, I didn't see anything preventing downgrading that to the minimum version I'd like to be using, 23. Opening this MR so that I can propose such a change 馃憤