Skip to content

Commit

Permalink
Migrate to required 'this.'
Browse files Browse the repository at this point in the history
  • Loading branch information
chadhietala committed May 20, 2018
1 parent ff05937 commit b61723b
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 27 deletions.
2 changes: 1 addition & 1 deletion app/templates/components/addon-list.hbs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<ul class="addon-list">
{{#each addons as |addon|}}
<li class="test-addon-row">
{{addon-details addon=addon showRanking=showRanking}}
{{addon-details addon=addon showRanking=this.showRanking}}
</li>
{{/each}}
{{yield}}
Expand Down
6 changes: 3 additions & 3 deletions app/templates/components/category-finder.hbs
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<h2 id="title">Categories</h2>
<ul>
{{#each sortedTopLevelCategories as |category|}}
{{#each this.sortedTopLevelCategories as |category|}}
<li title="{{category.description}}">
{{#link-to categoryLinkRoute category.slug class="test-category"}}
{{#link-to this.categoryLinkRoute category.slug class="test-category"}}
{{category.name}} ({{category.totalAddonCount}})
{{/link-to}}
</li>
{{#if category.subcategories}}
{{#each category.subcategories as |subcategory|}}
<li class="indent" title="{{subcategory.description}}">
{{#link-to categoryLinkRoute subcategory.slug class="test-subcategory"}}
{{#link-to this.categoryLinkRoute subcategory.slug class="test-subcategory"}}
<span class="bullet">&#9632;</span>
{{subcategory.name}} ({{subcategory.totalAddonCount}})
{{/link-to}}
Expand Down
2 changes: 1 addition & 1 deletion app/templates/components/comma-separated.hbs
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
{{yield item separator}}
{{yield item this.separator}}

8 changes: 4 additions & 4 deletions app/templates/components/inline-category-list.hbs
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{{#each categoriesSortedByAddonCount as |category|}}
{{#comma-separated list=categoriesSortedByAddonCount item=category as |value separator|}}
{{#each this.categoriesSortedByAddonCount as |category|}}
{{#comma-separated list=this.categoriesSortedByAddonCount item=category as |value separator|}}
{{#link-to "categories.show" value.slug}}
{{#if showWithoutParent}}
{{#if this.showWithoutParent}}
{{value.name}}
{{else}}
{{#if value.parent}}
{{value.parent.name}} >
{{/if}}
{{value.name}}
{{~/if~}}
{{#if showAddonCount}}
{{#if this.showAddonCount}}
({{value.totalAddonCount}})
{{~/if~}}
{{separator}}
Expand Down
28 changes: 14 additions & 14 deletions app/templates/components/large-search.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
id="search-input"
spellcheck="false"
value={{query}}
oninput={{action (perform search) value="target.value"}}>
oninput={{action (perform this.search) value="target.value"}}>
{{#if query}}
<button {{action clearSearch}} class="icon-close test-clear-search"></button>
{{/if}}
Expand All @@ -17,17 +17,17 @@
class="test-search-readmes"
id="search-readmes"
checked=searchReadmes
change=(action (perform toggleReadmeSearch))}}
change=(action (perform this.toggleReadmeSearch))}}
<label for="search-readmes">Search readmes</label>
</div>
<h6 class="no-results {{if hasSearchedAndNoResults 'showing'}}">No results found for "{{query}}"</h6>
<h6 class="no-results {{if this.hasSearchedAndNoResults 'showing'}}">No results found for "{{query}}"</h6>
</div>

{{#if results.length}}
{{#if this.results.length}}
<h4 class="result-info test-result-info">Results for "{{query}}"</h4>
{{#search-result-set results=results.displayingReadmes totalCount=results.totalReadmeCount fetchMore=fetchMoreReadmes title="Readmes" resultClass="readme-results"}}
{{#search-result-set results=this.results.displayingReadmes totalCount=this.results.totalReadmeCount fetchMore=fetchMoreReadmes title="Readmes" resultClass="readme-results"}}
<ul class="readme-list">
{{#each results.displayingReadmes as |addon|}}
{{#each this.results.displayingReadmes as |addon|}}
<li>
{{addon-details addon=addon}}
{{#each (get _results.readmeMatchMap addon.id) as |match|}}
Expand All @@ -39,9 +39,9 @@
{{/each}}
</ul>
{{/search-result-set}}
{{#search-result-set results=results.displayingCategories totalCount=results.totalCategoriesCount fetchMore=fetchMoreCategories title="Categories" resultClass="category-results"}}
{{#search-result-set results=this.results.displayingCategories totalCount=this.results.totalCategoriesCount fetchMore=fetchMoreCategories title="Categories" resultClass="category-results"}}
<ul>
{{#each results.displayingCategories as |category|}}
{{#each this.results.displayingCategories as |category|}}
<li>
{{#link-to "categories.show" category.slug}}
<span class="bullet">&#9632;</span>
Expand All @@ -51,12 +51,12 @@
{{/each}}
</ul>
{{/search-result-set}}
{{#search-result-set results=results.displayingAddons totalCount=results.totalAddonsCount fetchMore=fetchMoreAddons title="Addons" resultClass="addon-results"}}
{{addon-list addons=results.displayingAddons}}
{{#search-result-set results=this.results.displayingAddons totalCount=this.results.totalAddonsCount fetchMore=fetchMoreAddons title="Addons" resultClass="addon-results"}}
{{addon-list addons=this.results.displayingAddons}}
{{/search-result-set}}
{{#search-result-set results=results.displayingMaintainers totalCount=results.totalMaintainersCount fetchMore=fetchMoreMaintainers title="Maintainers" resultClass="maintainer-results"}}
{{#search-result-set results=this.results.displayingMaintainers totalCount=this.results.totalMaintainersCount fetchMore=fetchMoreMaintainers title="Maintainers" resultClass="maintainer-results"}}
<ul>
{{#each results.displayingMaintainers as |maintainer|}}
{{#each this.results.displayingMaintainers as |maintainer|}}
<li>
{{#link-to "maintainers.show" maintainer.name}}
<span class="bullet">&#9632;</span>
Expand All @@ -66,7 +66,7 @@
{{/each}}
</ul>
{{/search-result-set}}
{{else if search.isRunning}}
{{dot-spinner}}
{{else if this.search.isRunning}}
{{this.dot-spinner}}
{{/if}}
</div>
4 changes: 2 additions & 2 deletions app/templates/components/page-layout.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<li>
{{#link-to "about"}}About{{/link-to}}
</li>
{{#if session.isAuthenticated}}
{{#if this.session.isAuthenticated}}
<li>
<button {{action logoutUser}} class="logout">Log out</button>
</li>
Expand All @@ -51,7 +51,7 @@
{{yield}}
</div>
{{#if showCategories}}
{{category-finder class="categories-list" categories=categories}}
{{category-finder class="categories-list" categories=this.categories}}
{{/if}}
</div>
</div>
4 changes: 2 additions & 2 deletions app/templates/index.hbs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{#page-layout showCategories=true showHeaderSearch=false}}
{{large-search query=query searchReadmes=searchReadmes}}
{{route-index class="route-index" topAddons=model.topAddons newAddons=model.newAddons recentlyScoredAddons=model.recentlyScoredAddons}}
{{large-search query=this.query searchReadmes=this.searchReadmes}}
{{route-index class="route-index" topAddons=this.model.topAddons newAddons=this.model.newAddons recentlyScoredAddons=this.model.recentlyScoredAddons}}
{{/page-layout}}

0 comments on commit b61723b

Please sign in to comment.