Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exceptions should inherit from a common GeocodingException class #108

Closed
dfyx opened this issue Nov 2, 2018 · 1 comment
Closed

Exceptions should inherit from a common GeocodingException class #108

dfyx opened this issue Nov 2, 2018 · 1 comment
Labels
accepting-pull-requests

Comments

@dfyx
Copy link
Contributor

dfyx commented Nov 2, 2018

The provider-specific exception classes such as GoogleGeocodingException and BingGeocodingException should inherit from a common GeocodingException class. Otherwise you must either know which implementation of IGeocoder you're currently using (which isn't a good idea when using dependency injection) or you have to catch Exception (which might catch too much).
dfyx added a commit to dfyx/Geocoding.net that referenced this issue Nov 2, 2018
@dfyx
Add GeocodingException base class. Fixes chadly#108
585bf5c
@dfyx
Copy link
Contributor Author

dfyx commented Nov 2, 2018

Fixed by #109

@chadly chadly closed this as completed in b7ecb7b Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting-pull-requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfyx @chadly