Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReverseGeocoding: small double lat lng values issue #74

Conversation

alvillain
Copy link
Contributor

Added formatting for double coordinate values, since we can have small value like "0.00006" -> in double representation it will be "6E-05".
Request for Google in this case will fail (https://maps.googleapis.com/maps/api/geocode/xml?latlng=49.09500833,6E-05 ...)

I did not investigate the rest of the code, probably the same issue exists in Microsoft, Yahoo, MapQuest projects.

…e like "0.00006" -> in double representation it will be "6E-05"
@chadly
Copy link
Owner

chadly commented Sep 22, 2017

Thanks, I'd like to merge this but there appear to be some merge conflicts here. If you would resolve those, I will merge this in.

@alvillain
Copy link
Contributor Author

@chadly The merge conflicts were resolved.
But the build now is broken. Is there something wrong on the TeamCity?

@chadly chadly merged commit 4e565b8 into chadly:master Sep 26, 2017
@chadly
Copy link
Owner

chadly commented Sep 26, 2017

Yeah, teamcity is screwed up. I really need to update it to run the build correctly...

thanks, again

chadly pushed a commit that referenced this pull request Sep 26, 2017
Since we can have value like "0.00006" -> in double representation it will be "6E-05"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants