fix regression in recursive dir loops #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer COPY over ADD according to https://docs.docker.com/engine/articles/dockerfile_best-practices/#add-or-copy
|
Hi, thank you. Could you leave out commit 313acbd "upgrade to alpine 3.3 and use --no-cache option" from the pull request? For some reason it causes an "image ID '' is invalid" error on my tests with docker < 1.8 |
jumanjiman
force-pushed
the
regression
branch
from
313acbd
to
377f707
Compare
|
done! |
chadoe
added a commit
that referenced
this pull request
Dec 31, 2015
fix regression in recursive dir loops
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade to alpine 3.3 and use --no-cache optionindividual commit messages have additional details.