Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bug) MacOS copy/paste/duplicate happens twice with keyboard shortcuts #1590

Closed
joeyballentine opened this issue Feb 23, 2023 · 0 comments · Fixed by #2031
Closed

(bug) MacOS copy/paste/duplicate happens twice with keyboard shortcuts #1590

joeyballentine opened this issue Feb 23, 2023 · 0 comments · Fixed by #2031
Labels
bug Something isn't working MacOS Issue pertains specifically to MacOS

Comments

@joeyballentine
Copy link
Member

Mentioned by a user in the discord. The events fire twice on MacOS
@joeyballentine joeyballentine added the bug Something isn't working label Feb 23, 2023
@RunDevelopment RunDevelopment added the MacOS Issue pertains specifically to MacOS label Mar 9, 2023
stonerl added a commit to stonerl/chaiNNer that referenced this issue Aug 1, 2023
@stonerl
use native clipboard on macos
651818d 
On macOS we need the native Edit menu to make all keyboard shortcuts accessable.

The shortcuts can copy/cut/paste text and nodes. But using entries from the menu
itself only interacts with text.

Therefore on macOS a new menu is added: "Nodes"

Menu structure:

*Nodes
|
|- Undo
|- Redo
|--------
|- Cut
|- Copy
|- Paste
|--------
|- Duplicate
|- Duplicate with Connections

This menus sole purpose is to give the user a menu to interact with Nodes.

closes chaiNNer-org#958 chaiNNer-org#1590
stonerl added a commit to stonerl/chaiNNer that referenced this issue Aug 1, 2023
@stonerl
use native clipboard on macos
5f080a8 
On macOS we need the native Edit menu to make all keyboard shortcuts accessable.

The shortcuts can copy/cut/paste text and nodes. But using entries from the menu
itself only interacts with text.

Therefore on macOS a new menu is added: "Nodes"

Menu structure:

*Nodes
|
|- Undo
|- Redo
|--------
|- Cut
|- Copy
|- Paste
|--------
|- Duplicate
|- Duplicate with Connections

This menus sole purpose is to give the user a menu to interact with Nodes.

closes chaiNNer-org#958 chaiNNer-org#1590
@stonerl stonerl mentioned this issue Aug 1, 2023
Merged
stonerl added a commit to stonerl/chaiNNer that referenced this issue Aug 1, 2023
@stonerl
use native clipboard on macos
6390bd3 
On macOS we need the native Edit menu to make all keyboard shortcuts accessable.

The shortcuts can copy/cut/paste text and nodes. But using entries from the menu
itself only interacts with text.

Therefore on macOS a new menu is added: "Nodes"

Menu structure:

*Nodes
|
|- Undo
|- Redo
|--------
|- Cut
|- Copy
|- Paste
|--------
|- Duplicate
|- Duplicate with Connections

This menus sole purpose is to give the user a menu to interact with Nodes.

closes chaiNNer-org#958 chaiNNer-org#1590
stonerl added a commit to stonerl/chaiNNer that referenced this issue Aug 1, 2023
@stonerl
use native clipboard on macos
eb2b06e 
On macOS we need the native Edit menu to make all keyboard shortcuts accessable.

The shortcuts can copy/cut/paste text and nodes. But using entries from the menu
itself only interacts with text.

Therefore on macOS a new menu is added: "Nodes"

Menu structure:

*Nodes
|
|- Undo
|- Redo
|--------
|- Cut
|- Copy
|- Paste
|--------
|- Duplicate
|- Duplicate with Connections

This menus sole purpose is to give the user a menu to interact with Nodes.

closes chaiNNer-org#958 chaiNNer-org#1590
stonerl added a commit to stonerl/chaiNNer that referenced this issue Aug 2, 2023
@stonerl
use native clipboard on macos
c8339b1 
On macOS we need the native Edit menu to make all keyboard shortcuts accessable.

The shortcuts can copy/cut/paste text and nodes. But using entries from the menu
itself only interacts with text.

Therefore on macOS a new menu is added: "Nodes"

Menu structure:

*Nodes
|
|- Undo
|- Redo
|--------
|- Cut
|- Copy
|- Paste
|--------
|- Duplicate
|- Duplicate with Connections

This menus sole purpose is to give the user a menu to interact with Nodes.

closes chaiNNer-org#1590
joeyballentine pushed a commit that referenced this issue Aug 2, 2023
@stonerl
use native clipboard on macos (#2031)
5aab59b 
* use native clipboard on macos

On macOS we need the native Edit menu to make all keyboard shortcuts accessable.

The shortcuts can copy/cut/paste text and nodes. But using entries from the menu
itself only interacts with text.

Therefore on macOS a new menu is added: "Nodes"

Menu structure:

*Nodes
|
|- Undo
|- Redo
|--------
|- Cut
|- Copy
|- Paste
|--------
|- Duplicate
|- Duplicate with Connections

This menus sole purpose is to give the user a menu to interact with Nodes.

closes #1590

* added a Window menu on mac moved View menu

The View Menu is now located between Edit and Nodes to align it more with the default menu structure on macOS.

Also the Window Menu used on Macs has been added.
@stonerl stonerl mentioned this issue Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working MacOS Issue pertains specifically to MacOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use native clipboard on macos stonerl/chaiNNer
2 participants
@RunDevelopment @joeyballentine