Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Save Image' node can overlap Image Directory Iterator #1731

Closed
Raecaug opened this issue Apr 11, 2023 · 2 comments · Fixed by #2254
Closed

'Save Image' node can overlap Image Directory Iterator #1731

Raecaug opened this issue Apr 11, 2023 · 2 comments · Fixed by #2254
Labels
bug Something isn't working

Comments

@Raecaug
Copy link

Raecaug commented Apr 11, 2023

Information:

  • Chainner version: 0.18.5
  • OS: Windows 11
    Description
    It is possible for the save image node to extend outside the bounds of a directory iterator node, overlapping it.
    As seen here:

image

@Raecaug Raecaug added the bug Something isn't working label Apr 11, 2023
@RunDevelopment
Copy link
Member

That's a good find. Thank you for reporting @Raecaug!

I wonder what the indented behavior here is? Should we just relocate the child node to be in bounds, or should we extend the iterator's bounds?

@joeyballentine What do we currently do and why?

Whatever is the correct behavior, we need to update the bounds of child nodes more often. Because of type conditions, we need to update the bounds of all child nodes with groups whenever the global type state changes. I say type state because it includes all inputs and output overrides (so we can capture the changing state of starting nodes (e.g. auto reloading Load Image)).

@joeyballentine
Copy link
Member

I think the current correct behavior would be for it to be pushed in bounds, but i think I'd rather make it extend the iterator area instead if possible.

This reminds me: nodes can overflow out of an iterator when using snap to grid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants